-
Notifications
You must be signed in to change notification settings - Fork 6
Method added that is a converted version of LCA_tool_part_tostart.py #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Method added that is a converted version of LCA_tool_part_tostart.py #315
Conversation
Without being familiar with LCA, I think the missing translations are: |
@BHoMBot check compliance |
@EKAdebo to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@EKAdebo to confirm, the following actions are now queued:
|
@BHoMBot check required |
@EKAdebo to confirm, the following actions are now queued:
There are 12 requests in the queue ahead of you. |
The check |
The check |
2a86704
to
4ae32b5
Compare
@BHoMBot check core |
@EKAdebo to confirm, the following actions are now queued:
There are 29 requests in the queue ahead of you. |
The check |
@BHoMBot check required |
@EKAdebo to confirm, the following actions are now queued:
|
The check |
The check |
The check |
@BHoMBot check required |
@EKAdebo to confirm, the following actions are now queued:
|
The check |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 4 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything has now been resolved and demoed by @EKAdebo to match the Python script so happy to deploy this for further testing.
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 4 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #18
Converted the LCA_tool_part_tostart.py to C# and added it as an engine method.
Additional comments
As the script was originally in German I have tried to translate it, but have left some words as is, because I'm not sure of the translation. I have also tried to leave the script fairly similar to the original python script as I am not familiar with the calculations done within the script.