Skip to content

Method added that is a converted version of LCA_tool_part_tostart.py #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

EKAdebo
Copy link
Contributor

@EKAdebo EKAdebo commented Mar 30, 2023

Issues addressed by this PR

Closes #18

Converted the LCA_tool_part_tostart.py to C# and added it as an engine method.

Additional comments

As the script was originally in German I have tried to translate it, but have left some words as is, because I'm not sure of the translation. I have also tried to leave the script fairly similar to the original python script as I am not familiar with the calculations done within the script.

@EKAdebo EKAdebo added the type:feature New capability or enhancement label Mar 30, 2023
@EKAdebo EKAdebo requested a review from FraserGreenroyd March 30, 2023 16:51
@EKAdebo EKAdebo self-assigned this Mar 30, 2023
@EKAdebo EKAdebo linked an issue Mar 30, 2023 that may be closed by this pull request
@jamesramsden-bh
Copy link

Without being familiar with LCA, I think the missing translations are:
flachen = areas (I think it's supposed to be flächen, maybe you can't have umlauts in python?)
parken = car park / parking area
line 657 - I think 'hohe' is supposed to be 'height', maybe a tank height? (höhe = height)

@EKAdebo EKAdebo requested a review from FraserGreenroyd June 2, 2023 10:08
@EKAdebo
Copy link
Contributor Author

EKAdebo commented Jun 2, 2023

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 2, 2023

@EKAdebo to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@EKAdebo
Copy link
Contributor Author

EKAdebo commented Jun 6, 2023

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 6, 2023

@EKAdebo to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@EKAdebo EKAdebo requested a review from jamesramsden-bh June 6, 2023 15:17
@EKAdebo
Copy link
Contributor Author

EKAdebo commented Jun 6, 2023

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 6, 2023

@EKAdebo to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 12 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 6, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 6, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@EKAdebo EKAdebo force-pushed the LifeCycleAssessment_Toolkit-#18-convert-lca-from-python-into-c-engine-method branch from 2a86704 to 4ae32b5 Compare June 6, 2023 15:47
@EKAdebo
Copy link
Contributor Author

EKAdebo commented Jun 6, 2023

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 6, 2023

@EKAdebo to confirm, the following actions are now queued:

  • check core

There are 29 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 6, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@EKAdebo
Copy link
Contributor Author

EKAdebo commented Jun 7, 2023

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 7, 2023

@EKAdebo to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 7, 2023

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 7, 2023

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 7, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@EKAdebo
Copy link
Contributor Author

EKAdebo commented Jun 7, 2023

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 7, 2023

@EKAdebo to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 7, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 7, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance

There are 4 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything has now been resolved and demoed by @EKAdebo to match the Python script so happy to deploy this for further testing.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 7, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 4 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 962c412 into develop Jun 7, 2023
@FraserGreenroyd FraserGreenroyd deleted the LifeCycleAssessment_Toolkit-#18-convert-lca-from-python-into-c-engine-method branch June 7, 2023 18:02
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert LCA from Python into C# engine method
3 participants