-
Notifications
You must be signed in to change notification settings - Fork 6
Added National Highways dataset #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added National Highways dataset #285
Conversation
@BHoMBot check dataset-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 9 requests in the queue ahead of you. |
Please be advised that the check with reference 9138912711 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 26 additional annotations waiting, made up of 0 errors and 26 warnings. |
…ded conversion factors
@BHoMBot check dataset-compliance |
@BHoMBot check required |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@IsakNaslundBh @StephennipBH @michaelhoehn this is ready to be reviewed and incorporates the changes we discussed. |
@BHoMBot check required |
@michaelhoehn to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the datasets look great on testing and I'm happy to add them as is. I would however request that a simple case and error statement be added to the EvaluateEnvironmentalProductDeclaration
method to capture the added Energy
enum value.
This message can simply state something along the lines of "This calcuation has not yet been implemented, please perform the calculation manually or request this functionality in the LCA toolkit".
@BHoMBot check required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to merge this. Thanks @peterjamesnugent
@BHoMBot check required |
@michaelhoehn to confirm, the following actions are now queued:
|
@peterjamesnugent to confirm, the following actions are now queued:
|
NOTE: Depends on
BHoM/BHoM#1453
Issues addressed by this PR
Closes #284
Add the following dataset: https://nationalhighways.co.uk/suppliers/design-standards-and-specifications/carbon-emissions-calculation-tool/
Test files
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/LifeCycleAssessment_Toolkit/%23284-Add%20dataset%20for%20National%20Highways/Check%20dataset%20for%20National%20Highways.gh?csf=1&web=1&e=htB355
Changelog
EnvironmentalProductDeclaration
quantity has been set as the carbon factor x conversion factor and converted to SI unitsAdditional comments
I do have a few questions:
[Description("The number of units in reference to quantity type. Example, 1000 kg per unit quantityType of Mass.")]
EnvironmentalProductDeclaration
input QuantityTypeValue is described above - how does this relate to SI units? Or is the mass the exception because the units for GlobalWarmingPotential (GWP) is measured in tCO2?Normalise the carbon factors to SI units.
Add
energy
eNum forQuantityValueType
to `LifeCycleAssessment_oMDefined in km and then scaled by the mass transported.
CustomData
or is there a specific fragment?Added in AdditionalEPDInformation metric.
Include