Skip to content

Added National Highways dataset #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Oct 27, 2022

NOTE: Depends on

BHoM/BHoM#1453

Issues addressed by this PR

Closes #284

Add the following dataset: https://nationalhighways.co.uk/suppliers/design-standards-and-specifications/carbon-emissions-calculation-tool/

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/LifeCycleAssessment_Toolkit/%23284-Add%20dataset%20for%20National%20Highways/Check%20dataset%20for%20National%20Highways.gh?csf=1&web=1&e=htB355

Changelog

  • Added dataset from the National Highways Carbon Tool v2.5
  • The EnvironmentalProductDeclaration quantity has been set as the carbon factor x conversion factor and converted to SI units
  • The transport factors are to be scaled by the mass they are carrying

Additional comments

I do have a few questions:
[Description("The number of units in reference to quantity type. Example, 1000 kg per unit quantityType of Mass.")]

  • The EnvironmentalProductDeclaration input QuantityTypeValue is described above - how does this relate to SI units? Or is the mass the exception because the units for GlobalWarmingPotential (GWP) is measured in tCO2?
    Normalise the carbon factors to SI units.
  • The quantity types do not have an eNum for energy, one of the datasets has GWP for gas expressed as kgCO2e/kWh - so the quantity would be energy - what other methods need to be updated to include this eNum?
    Add energy eNum for QuantityValueType to `LifeCycleAssessment_oM
  • Similarly, there is data for laden vehicles expressed as tCO2e/(tkm) - so we would need a quantity that represented that.
    Defined in km and then scaled by the mass transported.
  • There are some notes on methodology - is this typically stored in the CustomData or is there a specific fragment?
    Added in AdditionalEPDInformation metric.
  • There are conversion factors part of the data (that I have included as it simplifies the calculation) - is there anywhere to note this?
    Include

@peterjamesnugent peterjamesnugent added the type:feature New capability or enhancement label Oct 27, 2022
@peterjamesnugent peterjamesnugent added this to the BHoM 6.0 β MVP milestone Oct 27, 2022
@peterjamesnugent peterjamesnugent self-assigned this Oct 27, 2022
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 27, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check dataset-compliance

There are 9 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 27, 2022

Please be advised that the check with reference 9138912711 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 26 additional annotations waiting, made up of 0 errors and 26 warnings.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check dataset-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 9, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@peterjamesnugent
Copy link
Member Author

@IsakNaslundBh @StephennipBH @michaelhoehn this is ready to be reviewed and incorporates the changes we discussed.

@michaelhoehn
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 10, 2022

@michaelhoehn to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Contributor

@michaelhoehn michaelhoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the datasets look great on testing and I'm happy to add them as is. I would however request that a simple case and error statement be added to the EvaluateEnvironmentalProductDeclaration method to capture the added Energy enum value.

This message can simply state something along the lines of "This calcuation has not yet been implemented, please perform the calculation manually or request this functionality in the LCA toolkit".

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

Copy link
Contributor

@michaelhoehn michaelhoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this. Thanks @peterjamesnugent

@michaelhoehn
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

@michaelhoehn to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@peterjamesnugent
Copy link
Member Author

@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@peterjamesnugent to confirm, the following actions are now queued:

  • check dataset-compliance
  • check copyright-compliance
  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 56d96e2 into main Nov 24, 2022
@FraserGreenroyd FraserGreenroyd deleted the LifeCycleAssessment_Toolkit-#-284-AddDatasetFromNationalHighaysCarbonTool branch November 24, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dataset from National Highways carbon emissions calculation tool
3 participants