Skip to content

Supporting core oM updates with removal of scope object classes #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

michaelhoehn
Copy link
Contributor

@michaelhoehn michaelhoehn commented Mar 3, 2022

NOTE: Depends on

BHoM/BHoM#1370

Issues addressed by this PR

Closes #264
Closes #248

Test files

Test file

Changelog

Additional comments

@michaelhoehn michaelhoehn added the type:feature New capability or enhancement label Mar 3, 2022
@michaelhoehn michaelhoehn self-assigned this Mar 3, 2022
@bhombot-ci
Copy link

bhombot-ci bot commented Mar 3, 2022

@michaelhoehn to confirm, the following checks are now queued:

  • core

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 3, 2022

@michaelhoehn just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 3, 2022

@michaelhoehn to confirm, the following checks are now queued:

  • core

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 3, 2022

@michaelhoehn just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

@michaelhoehn
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 4, 2022

@michaelhoehn to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@michaelhoehn
Copy link
Contributor Author

In a testing session with @enarhi we noticed that the user note for missing scopes was firing undesirably when called in a typical eval method. This note is being triggered in GetElementScope() and should possibly be moved to a different query more focused on curated reports at a later stage (something like IsScopeValid() when preparing a very specific report from study outputs).

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 7, 2022

@michaelhoehn just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2022

@michaelhoehn just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2022

@michaelhoehn just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 8, 2022

@michaelhoehn just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Mar 9, 2022

@michaelhoehn just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on BHoM

@michaelhoehn
Copy link
Contributor Author

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2022

@michaelhoehn to confirm, the following checks are now queued:

  • null-handling

@michaelhoehn
Copy link
Contributor Author

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2022

@michaelhoehn to confirm, the following checks are now queued:

  • serialisation

@michaelhoehn
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2022

@michaelhoehn to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2022

The check null-handling has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2022

The check serialisation has already been run previously and recorded as a successful check. This check has not been run again at this time.

getepdphases method
@michaelhoehn
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2022

@michaelhoehn to confirm, the following checks are now queued:

  • versioning

There are 18 requests in the queue ahead of you.

@michaelhoehn
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2022

@michaelhoehn to confirm, the following checks are now queued:

  • versioning

There are 27 requests in the queue ahead of you.

@michaelhoehn
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2022

@michaelhoehn to confirm, the following checks are now queued:

  • versioning

@michaelhoehn
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2022

@michaelhoehn to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@michaelhoehn
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2022

@michaelhoehn to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2022

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@michaelhoehn
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 11, 2022

@michaelhoehn to confirm, the following checks are now queued:

  • ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit e03592f into main Mar 12, 2022
@FraserGreenroyd FraserGreenroyd deleted the LifeCycleAssessment_oM-#1367-Remove-Scope-Objects branch March 12, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support changes from the oM removal of scope objects Improve performance of EvaluateMethods by Eliminating redundant method calls
3 participants