Skip to content

Fixed missing dependency to pytest #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

Tom-Kingstone
Copy link
Contributor

NOTE: Depends on BHoM/Python_Toolkit#181

Issues addressed by this PR

Closes #312

Test files

run run_tests.bat after fresh install

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone self-assigned this Jun 17, 2025
@Tom-Kingstone Tom-Kingstone added the type:bug Error or unexpected behaviour label Jun 17, 2025
@Tom-Kingstone Tom-Kingstone changed the title added pytest related packages to dependencies Fixed missing dependency to pytest Jun 17, 2025
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Jun 17, 2025

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 9 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

Copy link

bhombot-ci bot commented Jun 17, 2025

@Tom-Kingstone to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance

There are 9 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Jun 17, 2025

@Tom-Kingstone just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on Python_Toolkit

Copy link

bhombot-ci bot commented Jun 17, 2025

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@Tom-Kingstone Tom-Kingstone requested a review from Dmamedova June 18, 2025 10:05
Copy link
Contributor

@Dmamedova Dmamedova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

successful installation as well as all tests passing!

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check unit-tests
@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jun 18, 2025

@Tom-Kingstone to confirm, the following actions are now queued:

  • check unit-tests
  • check ready-to-merge

@jamesramsden-bh jamesramsden-bh merged commit 0ba5399 into develop Jun 18, 2025
12 checks passed
@jamesramsden-bh jamesramsden-bh deleted the Python_Toolkit-#180-AddPytest branch June 18, 2025 11:01
@BHoMBot BHoMBot mentioned this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pytest and pytest-cov to default dependencies
3 participants