Skip to content

Made walkability csv path relative instead of absolute #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Tom-Kingstone
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #306

made the path relative

Test files

Beta test procedure should pass

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone added the type:bug Error or unexpected behaviour label Apr 9, 2025
@Tom-Kingstone Tom-Kingstone self-assigned this Apr 9, 2025
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Apr 9, 2025

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check required

Copy link

bhombot-ci bot commented Apr 9, 2025

@jamesramsden-bh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Apr 9, 2025

@Tom-Kingstone to confirm, the following actions are now queued:

  • check unit-tests

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with automated tests and a manual spot check, method is outputting results as normal.

@jamesramsden-bh
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Apr 10, 2025

@jamesramsden-bh to confirm, the following actions are now queued:

  • check ready-to-merge

@jamesramsden-bh jamesramsden-bh merged commit 69f9dec into develop Apr 10, 2025
13 checks passed
@jamesramsden-bh jamesramsden-bh deleted the LadybugTools_Toolkit-#306-WalkabilityCsvPath branch April 10, 2025 09:06
@BHoMBot BHoMBot mentioned this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Walkability does not work for non-C based drives
2 participants