Height above ground in the wind class now defaults to 10.0 meters #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BHoMBot check required |
|
@jamesramsden-bh to confirm, the following actions are now queued:
|
jamesramsden-bh
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Happy with code change. Automated tests were run. Two tests were failing:
tests/test_categorical.py::test_annual_heatmap_histogram
tests/test_external_comfort/test_externalcomfort.py::test_plot_rh_heatmap
However, these are unrelated to the changes made and appear to be pre-existing in the develop branch. An issue will be raised for these separately.
|
@jamesramsden-bh to confirm, the following actions are now queued:
There are 3 requests in the queue ahead of you. |
|
@BHoMBot check ready-to-merge |
|
@jamesramsden-bh to confirm, the following actions are now queued:
There are 10 requests in the queue ahead of you. |
jamesramsden-bh
deleted the
LadybugTools_Toolkit-#277-WindHeightDefault
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #277
Previously no default value for heights above ground was provided.
Height above ground in the wind class now defaults to 10.0 meters
Test files
run python automated testing batch file
Changelog
Additional comments