Prevent push error when push is successful #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FraserGreenroyd
requested review from
rboulton-BH,
jamesramsden-bh,
robinflyman and
emilsvedjer
|
@BHoMBot check required |
|
@jamesramsden-bh can you double check the second commit? I spotted it while doing this, seemed appropriate, so not sure how it first got through review? |
|
@FraserGreenroyd to confirm, the following checks are now queued:
There are 5 requests in the queue ahead of you. |
|
Please be advised that the check with reference 5574625406 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 938 additional annotations waiting, made up of 938 errors and 0 warnings. |
|
@FraserGreenroyd to confirm, the following checks are now queued:
|
jamesramsden-bh
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Fixes #189
Test files
See issue.
Additional comments
Push component may warnings as noted in the image below, this is acceptable.