Skip to content

Turn on settings change ability within Grasshopper #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #698

As discussed and requested by @michaelhoehn

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Mar 1, 2024
@FraserGreenroyd FraserGreenroyd self-assigned this Mar 1, 2024
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check project-compliance

Copy link

bhombot-ci bot commented Mar 1, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check project-compliance

There are 1 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Mar 1, 2024

@FraserGreenroyd fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 22175334906

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot fix project file ref. 22175334906

Copy link

bhombot-ci bot commented Mar 1, 2024

@FraserGreenroyd I have queued up your request to fix the csproj file(s). There are 1 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Mar 1, 2024

@FraserGreenroyd I am now going to fix the project compliance in accordance with the annotations previously made.

Copy link

bhombot-ci bot commented Mar 1, 2024

@FraserGreenroyd to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Mar 1, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 1 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Mar 1, 2024

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is copyright-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 22175410770

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 22175410770

Copy link

bhombot-ci bot commented Mar 1, 2024

@FraserGreenroyd I have now provided a passing check on reference 22175410770 as requested.

Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and when setting the input to true, opens the settings menu properly with all of its functionality intact, and closes properly when saving/closing.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning
@BHoMBot check installer
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Mar 1, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check installer
  • check core
  • check null-handling
  • check serialisation

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link
Contributor

@michaelhoehn michaelhoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Happy to see this merged. Tested and working as expected.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Mar 1, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 9054958 into develop Mar 1, 2024
@FraserGreenroyd FraserGreenroyd deleted the BHoM_UI-#215-Settings branch March 1, 2024 20:05
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BHoM UI Settings in Grasshopper UI
4 participants