Update prototype interface for components #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adding new Attribute for ValueList - Migrating rendering logic to separate method
al-fisher
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Amazing - thanks @IsakNaslundBh
This is looking really good. Massively helps with clarity and highlighting on canvas.
Tested briefly and all working as expected for me:
And trying out on types, and different nodes - looks good across a variety of components as you have shown.
Approving - but happy to wait for merging to give @adecler and others chance to review and look at code etc.
|
@BHoMBot check required |
|
@al-fisher to confirm, the following checks are now queued:
|
|
@BHoMBot check copyright-compliance |
|
@IsakNaslundBh to confirm, the following checks are now queued:
|
IsakNaslundBh
deleted the
Grasshopper_Toolkit=#633-UpdateToPrototypeInterface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #633
Updated the interface to reflect what was shown in the issue. Yellow background added, alignment with jagged edges added and size increased.
Test files
Changelog
Additional comments
Some fiddeling needed to get the stripes to never cut the textbox in a corner, reason for the two for loops drawing the stripes.