Skip to content

Update force strings for 10.2 #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 27, 2025

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Apr 17, 2025

Issues addressed by this PR

Closes #323

Test files

Test script
Test script for 8.1 release
Installer

Changelog

  • Updated force strings used to send commands to GSA (also applicable for 8.7 and 10.1).

Additional comments

@peterjamesnugent peterjamesnugent added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Apr 17, 2025
@peterjamesnugent peterjamesnugent self-assigned this Apr 17, 2025
@peterjamesnugent
Copy link
Member Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Apr 17, 2025

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

There are 4 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Apr 17, 2025

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

There are 5 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Apr 17, 2025

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

There are 5 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Apr 17, 2025

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 5 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Apr 17, 2025

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

1 similar comment
Copy link

bhombot-ci bot commented Apr 17, 2025

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@njsmithies
Copy link
Contributor

Bar Loads can now be pushed correctly to GSA 10.2 (differential temp not implemented)
Panel Loads can now be pushed correctly to GSA 10.2 (area/area differential temp not implemented)
image

Point loads can be pulled and are pulled correctly.

Bar Prestress load pull produces the following error:

  1. This component failed to run properly.
  • Error: Input string was not in a correct format.
  • Occured in BH.Adapter.GSA.Convert.FromGsaBarPrestressLoad(String gsaString, Dictionary2 lCases, Dictionary2 bars, Double unitFactor)
    called from BH.Adapter.GSA.GSA102Adapter.<>c__DisplayClass35_0.b__0(String x)
  • Are you sure you have the correct type of inputs? Check their description for more details.

No other loads are implemented to be pulled using GSA

@peterjamesnugent
Copy link
Member Author

Thanks @njsmithies for testing! I have added a commit to add the names for BarPrestressLoad and BarTemperatureLoad.

As for the pull, they are not supported and outside the scope of this PR as per the wiki: https://github.com/BHoM/GSA_Toolkit/wiki/BHoM---GSA-object-relations#loading

If you need them for a workflow, add an issue and we can get them added.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Apr 23, 2025

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

@johannaisak
Copy link
Contributor

Thanks @njsmithies for testing! I have added a commit to add the names for BarPrestressLoad and BarTemperatureLoad.

As for the pull, they are not supported and outside the scope of this PR as per the wiki: https://github.com/BHoM/GSA_Toolkit/wiki/BHoM---GSA-object-relations#loading

If you need them for a workflow, add an issue and we can get them added.

@peterjamesnugent not sure about 10.1 but Pull for BarPrestressLoad is definitely implemented in 8.7. Please can we get it added to 10.1/10.2 as well?
image

@peterjamesnugent
Copy link
Member Author

@BHoMBot check installer

Copy link
Contributor

@johannaisak johannaisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not working currently - apparently despite specifying LOAD_BEAM_PRE.2 it pulls LOAD_BEAM_PRE for GSA8.9 and LOAD_BEAM_PRE.3 for GSA10.2.... So will probably need something that manages the string differently depending on what it has pulled

8.9:
image

10.2:
image

Copy link
Contributor

@johannaisak johannaisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull BarPrestressLoad now works for 8.9, 10.1 and 10.2

@peterjamesnugent
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented May 22, 2025

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

Copy link

bhombot-ci bot commented May 22, 2025

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented May 22, 2025

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented May 22, 2025

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@peterjamesnugent peterjamesnugent merged commit 1b363c5 into develop May 27, 2025
12 checks passed
@peterjamesnugent peterjamesnugent deleted the GSA_Toolkit-#323-FixBugForBarUDL branch May 27, 2025 08:39
@BHoMBot BHoMBot mentioned this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GSA Test Bug_Test 2_Create & Read Loads
3 participants