-
Notifications
You must be signed in to change notification settings - Fork 2
Pull Spacer and SpacerProperty #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull Spacer and SpacerProperty #270
Conversation
Functionality to pull spacers. Also GSA10 fix for reading bars which may or may not be needed.
Needed for push of spacers with existing spacer properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested for both GSA10.1 and GSA8.7 on test files and used the pull request successfully in another project. All works. Very useful.
The base branch was changed.
@TosteSkDa can you reapprove following base branch change |
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code reviewed only
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check required |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 12 requests in the queue ahead of you. |
The check |
The check |
The check |
FAO: @FraserGreenroyd The check they wish to have dispensation on is copyright-compliance. If you are providing dispensation on this occasion, please reply with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on @TosteSkDa functionality review as last commit was just for compliance and tidy up.
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 10527588795 |
@FraserGreenroyd I have now provided a passing check on reference |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
Functionality to pull spacers. Also GSA10 fix for reading bars which may or may not be needed.
NOTE: Depends on
Issues addressed by this PR
Closes #269
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/GSA_Toolkit/%23270-Pull%20Spacers%20and%20SpacerPropery?csf=1&web=1&e=gVTytn
Changelog
Additional comments