Skip to content

Add controls for setting residuals to be used for Non-linear tasks #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Mar 25, 2021

NOTE: Depends on

Issues addressed by this PR

Closes #236

Adding control over:

  • Resdiual force and moment for non-linear combinations
  • If BeamSlendernessEffect should be taken into account for non-linear combinations

Making Cases depend on combinations so that cases are pushed in when combinations are.

Test files

Testscript pushing combinations with varied settings and also checking that pushing without fragment assigned works.

https://burohappold.sharepoint.com/:f:/s/BHoM/EgbK4bHB-kxIr4wiRKXyON8BB0tUUQZvA-k2grsaKk22gg?e=GSzSRN

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh self-assigned this Mar 25, 2021
@IsakNaslundBh IsakNaslundBh added status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge type:feature New capability or enhancement labels Mar 25, 2021
@IsakNaslundBh IsakNaslundBh force-pushed the GSA_Toolkit-#236-AddControlOfSettingResidulasForAnalysisCases branch from fe09dd2 to 8d927d9 Compare December 3, 2021 09:04
@IsakNaslundBh IsakNaslundBh marked this pull request as ready for review December 3, 2021 09:40
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 3, 2021

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 3, 2021

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

There are 16 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 3, 2021

@IsakNaslundBh to confirm, the following checks are now queued:

  • copyright-compliance

There are 33 requests in the queue ahead of you.

johannaisak
johannaisak previously approved these changes Dec 3, 2021
Copy link
Contributor

@johannaisak johannaisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 3, 2021

@IsakNaslundBh to confirm, the following checks are now queued:

  • project-compliance

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 3, 2021

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 3, 2021

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 3, 2021

@IsakNaslundBh to confirm, the following checks are now queued:

  • copyright-compliance

There are 12 requests in the queue ahead of you.

Copy link
Contributor

@johannaisak johannaisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 3, 2021

@IsakNaslundBh to confirm, the following checks are now queued:

  • ready-to-merge

There are 53 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Dec 3, 2021
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 3, 2021

@IsakNaslundBh to confirm, the following checks are now queued:

  • ready-to-merge

There are 23 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 3, 2021

@IsakNaslundBh to confirm, the following checks are now queued:

  • ready-to-merge

There are 20 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 3, 2021

@IsakNaslundBh to confirm, the following checks are now queued:

  • ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit 242aee9 into main Dec 3, 2021
@IsakNaslundBh IsakNaslundBh deleted the GSA_Toolkit-#236-AddControlOfSettingResidulasForAnalysisCases branch December 3, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GSA_Toolkit: Add control of setting residual forces and moments for combinations
2 participants