Skip to content

Remove 5.3 Previous Version Attributes #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Sep 27, 2022

Remove 5.3 Previous Version Attributes

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Sep 27, 2022
@FraserGreenroyd FraserGreenroyd self-requested a review September 27, 2022 13:26
@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@FraserGreenroyd
Copy link
Contributor

FraserGreenroyd commented Sep 27, 2022

@BHoMBot check code-compliance
@BHoMBot check documentation-compliance
@BHoMBot check dataset-compliance
@BHoMBot check project-compliance
@BHoMBot check copyright-compliance
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check dataset-compliance
  • check project-compliance
  • check copyright-compliance
  • check core
  • check null-handling
  • check serialisation

There are 67 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 8574647207

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 8574647207

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@FraserGreenroyd I have now provided a passing check on reference 8574647207 as requested.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from a DevOps perspective after code review.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 27, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 1 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 2e871a4 into main Sep 27, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM-RemovePreviousVersion53 branch September 27, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants