-
Notifications
You must be signed in to change notification settings - Fork 3
Add ability to push multiple tables without reopening the file every time #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@BHoMBot check compliance |
@adecler to confirm, the following actions are now queued:
|
@BHoMBot check required |
@adecler to confirm, the following actions are now queued:
There are 4 requests in the queue ahead of you. |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with @adecler and @alelom today amongst various other things and we're in agreement with the plan to merge these for now to unblock @adecler on the work he's doing, with @alelom and others having a planning session and this issue to further enhance the adapter to unblock various aspects which this work has highlighted.
Happy to approve for now and we can rename PushItem
to something better before the beta if we don't resolve the above but it's all planned in 😄
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #53
Test files
EC_Report_SpeedTest.zip
This proves to be especially relevant when the Excel adapter is used by another toolkit to produce report.
So, the best way to test this is via this PR: https://github.com/BuroHappoldEngineering/StructureEmbodiedCarbon_Toolkit/pull/31
I recommend to test the Excel PR first without the other one to make sure everything is still working when pushing one table at a time. Once that confirmed to be working, recompile the other repo using the PR and confirm that the component is still working and is faster. Personally, I got this computational time: