Skip to content

Add ability to push multiple tables without reopening the file every time #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

adecler
Copy link
Member

@adecler adecler commented Jan 9, 2024

Issues addressed by this PR

Closes #53

Test files

EC_Report_SpeedTest.zip

This proves to be especially relevant when the Excel adapter is used by another toolkit to produce report.
So, the best way to test this is via this PR: https://github.com/BuroHappoldEngineering/StructureEmbodiedCarbon_Toolkit/pull/31

I recommend to test the Excel PR first without the other one to make sure everything is still working when pushing one table at a time. Once that confirmed to be working, recompile the other repo using the PR and confirm that the component is still working and is faster. Personally, I got this computational time:

image

@adecler adecler added the type:feature New capability or enhancement label Jan 9, 2024
@adecler adecler self-assigned this Jan 9, 2024
@adecler
Copy link
Member Author

adecler commented Jan 9, 2024

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 9, 2024

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@adecler
Copy link
Member Author

adecler commented Jan 11, 2024

@BHoMBot check required

Copy link

bhombot-ci bot commented Jan 11, 2024

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 4 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Jan 11, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jan 11, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @adecler and @alelom today amongst various other things and we're in agreement with the plan to merge these for now to unblock @adecler on the work he's doing, with @alelom and others having a planning session and this issue to further enhance the adapter to unblock various aspects which this work has highlighted.

Happy to approve for now and we can rename PushItem to something better before the beta if we don't resolve the above but it's all planned in 😄

@FraserGreenroyd
Copy link

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jan 11, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit bf92d0d into develop Jan 11, 2024
@FraserGreenroyd FraserGreenroyd deleted the Excel_Toolkit-#53-MultiItemPush branch January 11, 2024 19:51
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to push multiple items in one go to avoid long waiting times
2 participants