Skip to content

Created ExcelToolkitWiki.cs #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Conversation

desaiwangBH
Copy link
Contributor

@desaiwangBH desaiwangBH commented Jun 9, 2023

Issues addressed by this PR

Closes #30

  • method returns the wiki documentation link
  • resolves reference to Excel_Toolkit wiki inside UI_Ribbon (see issue here).

Test files

Changelog

Additional comments

returns the wiki documentation link
@desaiwangBH desaiwangBH added the type:feature New capability or enhancement label Jun 9, 2023
@desaiwangBH desaiwangBH self-assigned this Jun 9, 2023
Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good

@FraserGreenroyd
Copy link

@BHoMBot check core
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 3 requests in the queue ahead of you.

@FraserGreenroyd
Copy link

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link

@BHoMBot check versioning
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check null-handling
  • check serialisation

@FraserGreenroyd
Copy link

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning, ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 5133672 into develop Jun 9, 2023
@FraserGreenroyd FraserGreenroyd deleted the Excel_Toolkit-#30-WikiURL branch June 9, 2023 22:33
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExcelToolkitWiki
2 participants