Skip to content

Add ability to pull worksheet names from an Excel workbook #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 8, 2023

Conversation

FraserGreenroyd
Copy link

@FraserGreenroyd FraserGreenroyd commented Jun 8, 2023

Issues addressed by this PR

Fixes #27

Test files

Available here - a GH file and an Excel file linked to test with.

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Jun 8, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Jun 8, 2023
@FraserGreenroyd
Copy link
Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@desaiwangBH desaiwangBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Tested with my own file and I like the search function, especially as it is case insensitive :)

@FraserGreenroyd
Copy link
Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 20d89e8 into develop Jun 8, 2023
@FraserGreenroyd FraserGreenroyd deleted the Excel_Toolkit-#27-WorksheetNames branch June 8, 2023 19:59
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to get all worksheets from a given Excel file
2 participants