Skip to content

Excel adapter fixed to allow for enum values #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2023

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Mar 14, 2023

NOTE: Depends on

BHoM/BHoM_Engine#3020

Issues addressed by this PR

Closes #14

Test files

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Mar 14, 2023
@pawelbaran pawelbaran self-assigned this Mar 14, 2023
@FraserGreenroyd FraserGreenroyd requested a review from adecler March 14, 2023 18:36
@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check compliance
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 14, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check null-handling
  • check serialisation

There are 8 requests in the queue ahead of you.

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Enum, it is better to use IToText so it makes use of the DisplayText attribute.
Given that IToText needs to be improve to support primitives, I woudl suggest something like this for now: y => y is Enum ? y.IToText() : y.ToString() (to be tested)
Unless, you want to fix the IToText for primitives of course 😄

@pawelbaran pawelbaran requested a review from adecler March 15, 2023 10:41
@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 15, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 7 requests in the queue ahead of you.

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me.
I have noticed some issue when goDeep is set to true but this is unrelated to this PR so I have raised a separate issue (#16) and will fix once this one is merged

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 15, 2023

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine

@pawelbaran
Copy link
Member Author

@BHoMBot check serialisation
@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 15, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check serialisation
  • check null-handling

There are 14 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 15, 2023

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 15, 2023

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM_Engine

@vietle-bh vietle-bh removed their request for review March 16, 2023 13:54
@bhombot-ci
Copy link

bhombot-ci bot commented Mar 18, 2023

@pawelbaran just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@FraserGreenroyd FraserGreenroyd merged commit fea9b01 into develop Mar 18, 2023
@FraserGreenroyd FraserGreenroyd deleted the Excel_Toolkit-#14-EnumValueBug branch March 18, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excel adapter leaves the sheet empty if inputs contain enum values
3 participants