-
Notifications
You must be signed in to change notification settings - Fork 3
Excel adapter fixed to allow for enum values #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@pawelbaran to confirm, the following actions are now queued:
There are 8 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Enum, it is better to use IToText
so it makes use of the DisplayText
attribute.
Given that IToText
needs to be improve to support primitives, I woudl suggest something like this for now: y => y is Enum ? y.IToText() : y.ToString()
(to be tested)
Unless, you want to fix the IToText
for primitives of course 😄
@pawelbaran to confirm, the following actions are now queued:
There are 7 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well for me.
I have noticed some issue when goDeep
is set to true but this is unrelated to this PR so I have raised a separate issue (#16) and will fix once this one is merged
@pawelbaran just to let you know, I have provided a |
@pawelbaran to confirm, the following actions are now queued:
There are 14 requests in the queue ahead of you. |
@pawelbaran just to let you know, I have provided a |
@pawelbaran just to let you know, I have provided a |
@pawelbaran just to let you know, I have provided a |
NOTE: Depends on
BHoM/BHoM_Engine#3020
Issues addressed by this PR
Closes #14
Test files
Changelog
Additional comments