Skip to content

8.0 Deployment #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 73 commits into from
Dec 19, 2024
Merged

8.0 Deployment #484

merged 73 commits into from
Dec 19, 2024

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Dec 9, 2024

ETABS_Toolkit

Feature

  • Add Spandrel Force Result
    • Added SpandrelForce Class to the ETABS_oM Results namespace
    • Added SpandrelForce value to Enum PierAndSpandrelResultType in the Requests namespace
    • Added calls to ETABS API functions to extract Spandrel Forces from ETABS Model in the ETABS Adapter
  • Extract Mesh VonMises Stresses
    • Added methods ReadMeshVonMises, SmoothenVonMisesStresses and ComputeVonMisesMoment to read/compute Von Mises stresses from etabs shell objects.
    • Added utility method GetPanelThickness for getting the thickness of etabs panels
  • Extract Story Drifts
    • Added StoryDrift Class to BHoM Structure Global Results
    • Added GetStoryDrifts Method to ETABS Toolkit Read Global Results
  • Fix Issue with Pushing Levels by using PriorityTypes
    • Added class "PriorityTypes"
    • Added implementation of HandlePriorities attribute for the ETABS Adapter
  • Get ETABS File Path
    • Added public and readonly attribute FilePath to the ETABSAdapter Class
    • Added assignment of the FilePath attribute in the Constructor of the ETABSAdapter Class

Bug

  • Improve Move Objects Update Feature
    • Use of Hash Tables to store and access faster data for moving nodes
    • Use of Streams on Hash Tables to run the ETABS API .move() method faster on nodes grouped together

Compliance

GCRA101 and others added 30 commits August 12, 2024 11:50
Since Area objects have the diffload defined in the 3-3 Axis, the corresponding
Type Number is 3...not 2.
In line with what already done with PierForce
No Von Mises Flexural Moment gets extracted since it's not a direct output given by ETABS.
It could be possibly computed within the BHoM in case it's required.
The Von Mises Moment is not returned by ETABS natively and it must be computed directly in the BHoM from the Von Mises stresses diagram.
Duplication removed.
Thickness of panels is extracted differently depending on the type of deck/slab/wall section property assigned to the panel.
The ETABS API provides different functions for each of their types and they must be all called somehow until the correct one gets hit.
The control parameter is the integer ouput ret of the ETABS API functions (0=Worked Fine, 1=Failed)
Rather than moving each node one by one, all nodes are grouped into different buckets based on same movement in x/y/z direction.
In this way, it is possible to call the .move() method on multiple nodes rather than on a single node at the time.
This makes the algorithm much faster taking advantage of the pros of the Hash Tables data structure.
Copy link

bhombot-ci bot commented Dec 10, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

Copy link

bhombot-ci bot commented Dec 10, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

Copy link

bhombot-ci bot commented Dec 10, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on SQL_Toolkit

Copy link

bhombot-ci bot commented Dec 11, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

Copy link

bhombot-ci bot commented Dec 11, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

Copy link

bhombot-ci bot commented Dec 11, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on SQL_Toolkit

Copy link

bhombot-ci bot commented Dec 12, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

Copy link

bhombot-ci bot commented Dec 12, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM

Copy link

bhombot-ci bot commented Dec 12, 2024

@IsakNaslundBh I am now running force checks on the checks requested. These will be queued and actioned ASAP.

Copy link

bhombot-ci bot commented Dec 12, 2024

@IsakNaslundBh I have provided force checks to the checks requested.

Copy link

bhombot-ci bot commented Dec 13, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM_Engine

Copy link

bhombot-ci bot commented Dec 13, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoM_Engine

Copy link

bhombot-ci bot commented Dec 13, 2024

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on BHoMAnalytics_Toolkit

Copy link

bhombot-ci bot commented Dec 16, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on Revit_UI

Copy link

bhombot-ci bot commented Dec 16, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @BHoMBot on Revit_Schematic_Tool

@bhombot-ci bhombot-ci bot added the type:feature New capability or enhancement label Dec 16, 2024
Copy link

bhombot-ci bot commented Dec 17, 2024

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on Revit_Tagging_Tool

Copy link
Contributor

@Chrisshort92 Chrisshort92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Gabriel Yakoub and @GCRA101, Tested against installer on 241216. Functionality working as expected. Some minor bugs to be addressed in coming milestone that are non-critical to functionality. Passed for merge.

Copy link
Contributor

@GCRA101 GCRA101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with review comments from @Chrisshort92 .
Approved.

Copy link

bhombot-ci bot commented Dec 19, 2024

@BHoMBot just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@adecler adecler merged commit 141b23d into main Dec 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants