Skip to content

Add Adapter Support for Structure Openings #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GCRA101
Copy link
Contributor

@GCRA101 GCRA101 commented Oct 1, 2024

@GCRA101 GCRA101 self-assigned this Oct 1, 2024
@GCRA101 GCRA101 added this to the BHoM 7.4 β MVP milestone Oct 1, 2024
@GCRA101 GCRA101 added the type:feature New capability or enhancement label Oct 1, 2024
Chrisshort92
Chrisshort92 previously approved these changes Oct 13, 2024
Copy link
Contributor

@Chrisshort92 Chrisshort92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality has been tested and verified against test scripts and files. Approved for merge

@Chrisshort92
Copy link
Contributor

@BHoMBot check required

Copy link

bhombot-ci bot commented Oct 13, 2024

@Chrisshort92 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@peterjamesnugent
Copy link
Member

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Oct 23, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance

There are 31 requests in the queue ahead of you.

@GCRA101
Copy link
Contributor Author

GCRA101 commented Oct 28, 2024

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Oct 28, 2024

@GCRA101 to confirm, the following actions are now queued:

  • check ready-to-merge

There are 26 requests in the queue ahead of you.

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a dependency type of Panel as you would not push an Opening independently.

See here what we did for Lusas:
https://github.com/BHoM/Lusas_Toolkit/blob/24b2f3212ded178e410d8cdb36609d3001fd74f9/Lusas_Adapter/LusasAdapter.cs#L140

Equally, we need to update the code for Panel when you read it, that reads the Openings and assigns them appropriately.

@peterjamesnugent
Copy link
Member

@GCRA101 have you added the dependency type for Openings?

@GCRA101
Copy link
Contributor Author

GCRA101 commented Jan 20, 2025

@peterjamesnugent,
thanks for your comments.

@peterjamesnugent , @Chrisshort92, updated code now on GitHub at the following commit: 9119e2f Panels and Opening objects are now decoupled ;).

Grasshopper file updated to allow testing with mixed selection of panels and openings (saved at same link as before): https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23479-AddSupportForStructureOpenings/Test%20Script.gh?csf=1&web=1&e=fdeQlU

@GCRA101 GCRA101 requested a review from Chrisshort92 January 20, 2025 18:43
Copy link

bhombot-ci bot commented Feb 18, 2025

@GCRA101 fix requested for copyright headers.

The errors with the copyright headers on the CS (.cs) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

Each CS (.cs) file that does not have the current copyright header will have it applied. The current copyright header can be examined here.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix copyright headers ref. 35907376382

@GCRA101
Copy link
Contributor Author

GCRA101 commented Feb 18, 2025

@BHoMBot fix copyright headers ref. 35907376382

Copy link

bhombot-ci bot commented Feb 18, 2025

@GCRA101 I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Feb 18, 2025

@GCRA101 I am now going to fix the copyright compliance in accordance with the annotations previously made.

Copy link

bhombot-ci bot commented Feb 18, 2025

@GCRA101 to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.

@BHoM BHoM deleted a comment from bhombot-ci bot Feb 18, 2025
@BHoM BHoM deleted a comment from bhombot-ci bot Feb 18, 2025
@GCRA101
Copy link
Contributor Author

GCRA101 commented Feb 18, 2025

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Feb 18, 2025

@GCRA101 to confirm, the following actions are now queued:

  • check copyright-compliance

@GCRA101
Copy link
Contributor Author

GCRA101 commented Feb 18, 2025

@BHoMBot check required

Copy link

bhombot-ci bot commented Feb 18, 2025

@GCRA101 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 19 requests in the queue ahead of you.

@BHoM BHoM deleted a comment from bhombot-ci bot Feb 18, 2025
Copy link

bhombot-ci bot commented Feb 18, 2025

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@GCRA101
Copy link
Contributor Author

GCRA101 commented Feb 18, 2025

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Feb 18, 2025

@GCRA101 to confirm, the following actions are now queued:

  • check copyright-compliance

There are 45 requests in the queue ahead of you.

@GCRA101 GCRA101 requested a review from albertbg028 February 25, 2025 17:03
Copy link

@albertbg028 albertbg028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working fine!
PR Review 479

@GCRA101
Copy link
Contributor Author

GCRA101 commented Feb 26, 2025

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Feb 26, 2025

@GCRA101 to confirm, the following actions are now queued:

  • check ready-to-merge

@GCRA101 GCRA101 dismissed peterjamesnugent’s stale review February 26, 2025 16:07

All changes have been incorporated. Code changes tested and approved.

@GCRA101
Copy link
Contributor Author

GCRA101 commented Feb 26, 2025

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Feb 26, 2025

@GCRA101 to confirm, the following actions are now queued:

  • check ready-to-merge

@GCRA101
Copy link
Contributor Author

GCRA101 commented Feb 26, 2025

fyi
@Chrisshort92 , @peterjamesnugent , PR ready to merge ;)

@peterjamesnugent peterjamesnugent merged commit 0efe807 into develop Feb 26, 2025
10 checks passed
@peterjamesnugent peterjamesnugent deleted the ETABS_Toolkit-#375-AddSupportForStructureOpenings branch February 26, 2025 16:18
@adecler adecler mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ETABS_Toolkit: Add adapter support for Structure.Elements.Opening
5 participants