-
Notifications
You must be signed in to change notification settings - Fork 10
Add Adapter Support for Structure Openings #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Adapter Support for Structure Openings #479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality has been tested and verified against test scripts and files. Approved for merge
@BHoMBot check required |
@Chrisshort92 to confirm, the following actions are now queued:
|
@BHoMBot check copyright-compliance |
@peterjamesnugent to confirm, the following actions are now queued:
There are 31 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@GCRA101 to confirm, the following actions are now queued:
There are 26 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add a dependency type of Panel
as you would not push an Opening
independently.
See here what we did for Lusas:
https://github.com/BHoM/Lusas_Toolkit/blob/24b2f3212ded178e410d8cdb36609d3001fd74f9/Lusas_Adapter/LusasAdapter.cs#L140
Equally, we need to update the code for Panel
when you read it, that reads the Opening
s and assigns them appropriately.
Co-authored-by: Peter Nugent <[email protected]>
@GCRA101 have you added the dependency type for |
@peterjamesnugent, @peterjamesnugent , @Chrisshort92, updated code now on GitHub at the following commit: 9119e2f Panels and Opening objects are now decoupled ;). Grasshopper file updated to allow testing with mixed selection of panels and openings (saved at same link as before): https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23479-AddSupportForStructureOpenings/Test%20Script.gh?csf=1&web=1&e=fdeQlU |
@GCRA101 fix requested for copyright headers. The errors with the copyright headers on the CS ( I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. Each CS ( If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix copyright headers ref. 35907376382 |
@GCRA101 I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you. |
@GCRA101 I am now going to fix the copyright compliance in accordance with the annotations previously made. |
@GCRA101 to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request. |
@BHoMBot check copyright-compliance |
@GCRA101 to confirm, the following actions are now queued:
|
@BHoMBot check required |
@GCRA101 to confirm, the following actions are now queued:
There are 19 requests in the queue ahead of you. |
The check |
@BHoMBot check copyright-compliance |
@GCRA101 to confirm, the following actions are now queued:
There are 45 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BHoMBot check ready-to-merge |
@GCRA101 to confirm, the following actions are now queued:
|
All changes have been incorporated. Code changes tested and approved.
@BHoMBot check ready-to-merge |
@GCRA101 to confirm, the following actions are now queued:
|
fyi |
Issues addressed by this PR
Closes #375
ETABS Toolkit now allows to push and pull Opening objects.
Test files
Grasshopper File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23479-AddSupportForStructureOpenings/Test%20Script.gh?csf=1&web=1&e=fdeQlU
ETABS File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23479-AddSupportForStructureOpenings/Test%20ETABS%20Model.EDB?csf=1&web=1&e=xXim64
Changelog