Skip to content

Change namespace to BH.Engine.Adapters.ETABS #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kThorsager
Copy link
Contributor

Issues addressed by this PR

Closes #318

Test files

a specific test to ensue versioning works
https://burohappold.sharepoint.com/:u:/s/BHoM/EbM06IormB9GtSa0M_svSa4BMZWmQZAEisZ33Qy2bpXNBQ?e=CbS9sZ

Otherwise, general macros

Changelog

Additional comments

No action seemed to be needed in the oM
And took the liberty to clean up the using statements in the files

From: BH.Engine.ETABS
To: BH.Engine.Adapters.ETABS
@kThorsager kThorsager added the type:compliance Non-conforming to code guidelines label Jun 2, 2020
@kThorsager kThorsager added this to the BHoM 3.2 β MVP milestone Jun 2, 2020
@kThorsager kThorsager self-assigned this Jun 2, 2020
@IsakNaslundBh
Copy link
Contributor

Minor tweak:

image

Good to change the default namespace to the one including Adapters

@IsakNaslundBh
Copy link
Contributor

/azp run ETABS_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and both versioning and general push pull works as before.

@IsakNaslundBh IsakNaslundBh merged commit ba9f350 into master Jun 3, 2020
@IsakNaslundBh IsakNaslundBh deleted the ETABS_Toolkit-#318-Change-namespace-of-oM-and-Engine branch June 3, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ETABS_Toolkit: Change namespace of oM and Engine
2 participants