Skip to content

Regenerate failing unit-tests #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Jun 19, 2025

Issues addressed by this PR

Closes #80

Fixes all broken UTs by regenerating them.

I tried checking that the data updated was ok, but that should be checked again to ensure you are happy with the updated output data from the new UTs.

This was missed due to unit-tests not run on #78 . It was not set as a required check, which it should have been. Will add it to the list of required checks.

Test files

Should be run with branch on develop:
On Sharepoint

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh self-assigned this Jun 19, 2025
@IsakNaslundBh IsakNaslundBh added the type:test-script Creation of unit test required label Jun 19, 2025
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Jun 19, 2025

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

There are 787 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh changed the title Update Offset.json Regenerate failing unit-tests Jun 19, 2025
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense, happy to approve

@pawelbaran
Copy link
Member

@BHoMBot check required

Copy link

bhombot-ci bot commented Jun 19, 2025

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@pawelbaran
Copy link
Member

@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Jun 19, 2025

@pawelbaran to confirm, the following actions are now queued:

  • check dataset-compliance
  • check copyright-compliance

@pawelbaran
Copy link
Member

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jun 19, 2025

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@pawelbaran pawelbaran merged commit 7ea53cc into develop Jun 19, 2025
12 checks passed
@pawelbaran pawelbaran deleted the Clipper_Toolkit-#80-FixBrokenUTs branch June 19, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:test-script Creation of unit test required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update broken UTs
2 participants