Skip to content

Upgrade .Net Framework to 4.7.2 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2021
Merged

Upgrade .Net Framework to 4.7.2 #36

merged 1 commit into from
Oct 1, 2021

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Sep 30, 2021

Upgrade to .Net Framework 4.7.2 for projects that were targetting a lower framework

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 30, 2021

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Adapter

3 similar comments
@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Adapter

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Adapter

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Adapter

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

IsakNaslundBh
IsakNaslundBh approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@IsakNaslundBh IsakNaslundBh added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Oct 1, 2021
@FraserGreenroyd
Copy link

@BHoMBot check required
@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning
  • dataset-compliance
  • copyright-compliance
  • ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 1, 2021

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd FraserGreenroyd merged commit 8cdd770 into main Oct 1, 2021
@FraserGreenroyd FraserGreenroyd deleted the BHoM-#1291-NetStandard branch October 1, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsakNaslundBh IsakNaslundBh IsakNaslundBh approved these changes

Assignees
No one assigned
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BHoMBot @FraserGreenroyd @IsakNaslundBh