Fixing Code Compliance issue on Create.InputAccessor and Create.OutputAccessor #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BHoMBot check code-compliance |
|
@adecler to confirm, the following actions are now queued:
There are 4 requests in the queue ahead of you. |
|
@IsakNaslundBh to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
IsakNaslundBh
approved these changes
Mar 22, 2025
There was a problem hiding this comment.
Happy with the code changes in here. Tested in Grasshopper and Excel, and things still functioning as expected.
@adecler I took the liberty to add the missing versioning attributes, but that means I should not be merging this as last committer, so leave that to you tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Fixes #512
See issue for details
Test files
Code compliance should now pass
Changelog
Additional comments