Skip to content

Add ProjectId to triggerUseageLogArgs and check if set and update ProjectId #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

Add ProjectId to triggerUseageLogArgs and check if set and update ProjectId #511

merged 1 commit into from
Mar 20, 2025

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Add support for retreiving projectId from events fired. If projectId is set upon return from TriggerUseageLog, then Id is used for the current file and set to update and stored for future useage.

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Mar 20, 2025
@IsakNaslundBh IsakNaslundBh self-assigned this Mar 20, 2025
michaelhoehn
michaelhoehn approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@michaelhoehn michaelhoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested with multiple project and non-project files in both Excel and Rhino 7 and have found this solution functional. Happy to approve.

adecler
adecler approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on code review and testing in Excel and Rhino 7

@adecler
Copy link
Member

adecler commented Mar 20, 2025

@BHoMBot check required

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Mar 20, 2025

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 1 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Mar 20, 2025

@IsakNaslundBh to confirm, the following actions are now queued:

  • check copyright-compliance
  • check ready-to-merge

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Mar 20, 2025

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit f88dc6a into develop Mar 20, 2025
10 checks passed
@IsakNaslundBh IsakNaslundBh deleted the BuroHappold_BHoMAnalytics_Toolkit-#72-TryExtractProjectIDFromFileName branch March 20, 2025 21:17
@IsakNaslundBh IsakNaslundBh mentioned this pull request Mar 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adecler adecler adecler approved these changes

@michaelhoehn michaelhoehn michaelhoehn approved these changes

@Chrisshort92 Chrisshort92 Awaiting requested review from Chrisshort92

Assignees

@IsakNaslundBh IsakNaslundBh

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IsakNaslundBh @adecler @michaelhoehn