-
Notifications
You must be signed in to change notification settings - Fork 6
Fix issue with versioning log and thread abort #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with versioning log and thread abort #509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested Rhino 8, Rhino 7, and excel with no issues and have verified logs. I'm happy with this solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Excel, Rhino 7 and Rhino 8, all providing expected behavior when opening two scripts in a row.
Here's the test files I used for Excel:
BuroHappold_BHoM_v5.3.beta_Loadcases and Combinations.zip
My only concern is that the versioning report form is frozen in an uncomplete state until the script has finished loading. I understand this is due to the form now loading on the same thread because this was the only option that got both forms showing on top and closing at appropriate time. So happy to get this approved as is for now and raise an issue to improve on the solution soon.
@BHoMBot check required |
@adecler to confirm, the following actions are now queued:
|
@BHoMBot check copyright-compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 9 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 27 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #508
Fixes an issue with the versioning log window. Previously was handled on a separate thread that was aborted on document close. Thread.Abort() is not supported in later runtimes, see This link.
This has now been refactored out by instead storing the versioning form in a static varibale, and closing and disposing it at document close and open.
Also changing from ShowDialog to Show and bringing it to top.
Test files
For grasshopper, this can be tested with files in here
Still need to also be tested with Excel as well as Revit.
Changelog
Additional comments