Skip to content

Updated URL to method calls #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2023
Merged

Updated URL to method calls #460

merged 1 commit into from
Jun 9, 2023

Conversation

desaiwangBH
Copy link
Contributor

Issues addressed by this PR

Closes #458

-constant strings changed to call DocumentationURL and BHoMWebsiteURL.

Test files

Changelog

Additional comments

@desaiwangBH
Updated URL to method calls
d071748 
-constant strings changed to call DocumentationURL and BHoMWebsiteURL.
@desaiwangBH desaiwangBH added the type:documentation Wiki, help or in code attributes label Jun 9, 2023
@desaiwangBH desaiwangBH self-assigned this Jun 9, 2023
FraserGreenroyd
FraserGreenroyd approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense on code review

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 2 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. Renew the cache.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2023

@FraserGreenroyd I'm sorry, but I am not authorised to take that instruction from you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. Renew the cache.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2023

@FraserGreenroyd I have updated the cache as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 9, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 59bf0b9 into develop Jun 9, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM_UI-#458-DocumentationURL branch June 9, 2023 20:58
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@travispotterBH travispotterBH Awaiting requested review from travispotterBH

Assignees

@desaiwangBH desaiwangBH

Labels
type:documentation Wiki, help or in code attributes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation URL
2 participants
@desaiwangBH @FraserGreenroyd