Versioning_Engine: Fix Issue with all dictionary entries throwing and catching exceptions #3518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #3517
Fixes problem with exceptions being thrown and caught for each entry in a non-string based dictionary going through the upgrading loop.
Could have fixed by checking if the document contains "_t" in the UpgradeObejct method, but this almost felt clearer in terms of data flow, as the UpgradeObejctProperties is the only method in UpgradeObejct that will be called for a non-existing _t (all other parts relies on the "oldType" property.
This PR should not really change anything it terms of functionality, just make it run quicker, and hopefully make the code flow cleaner
Test files
Changelog
Additional comments