Skip to content

Versioning_Engine: Fix Issue with all dictionary entries throwing and catching exceptions #3518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #3517

Fixes problem with exceptions being thrown and caught for each entry in a non-string based dictionary going through the upgrading loop.

Could have fixed by checking if the document contains "_t" in the UpgradeObejct method, but this almost felt clearer in terms of data flow, as the UpgradeObejctProperties is the only method in UpgradeObejct that will be called for a non-existing _t (all other parts relies on the "oldType" property.

This PR should not really change anything it terms of functionality, just make it run quicker, and hopefully make the code flow cleaner

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh self-assigned this Jun 13, 2025
@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Jun 13, 2025
@IsakNaslundBh IsakNaslundBh changed the title Fix Issue with all dictionary entries throwing and catching exceptions Versioning_Engine: Fix Issue with all dictionary entries throwing and catching exceptions Jun 13, 2025
@adecler
Copy link
Member

adecler commented Jun 17, 2025

@BHoMBot check compliance
@BHoMBot check required
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Jun 17, 2025

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check unit-tests

Copy link

bhombot-ci bot commented Jun 17, 2025

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jun 17, 2025

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the code changes and with all checks are passing

@adecler
Copy link
Member

adecler commented Jun 17, 2025

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jun 17, 2025

@adecler to confirm, the following actions are now queued:

  • check ready-to-merge

@adecler adecler merged commit 3f2e6f3 into develop Jun 17, 2025
13 checks passed
@adecler adecler deleted the Versioning_Engine-#3517-FixConstantExceptionThrowingForDictionariesBeingUpgraded branch June 17, 2025 11:20
@BHoMBot BHoMBot mentioned this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versioning_Engine: Constant exception throwing for instances in Dictionaries in Upgrade loop
2 participants