Verification_Engine: CSharpScript.EvaluateAsync fixed to only generate one assembly per formula #3494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelbaran
requested review from
al-fisher,
rwemay,
adecler and
FraserGreenroyd
as code owners
|
@pawelbaran Thanks for the quick fix! I’ll look into how I can apply it in my spreadsheet. |
michal-pekacki
approved these changes
Apr 29, 2025
|
@BHoMBot check ready-to-merge |
|
@michal-pekacki to confirm, the following actions are now queued:
There are 46 requests in the queue ahead of you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #3493
Test files
See #3493
Changelog
Additional comments
@linhnam-nguyen you may want to look into it - it is a quickfix for the issue you have raised under BHoM/Revit_Toolkit#1532. Your solution using Roslyn Emit is most likely more efficient, but this PR is meant to make the current mechanism at least usable, not necessarily perfect 😉