Skip to content

Reflection_Engine: StackOverflowException in PropertyFullNameValueGroups fixed #3482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

pawelbaran
Copy link
Member

Issues addressed by this PR

Closes #3481

Test files

See #3481

Changelog

Additional comments

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Mar 25, 2025
@pawelbaran pawelbaran self-assigned this Mar 25, 2025
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on code review and limited testing in Grasshopper.

Worth noting that PropertyFullNameValueDictionary component is returning null while we should expect a dictionary. It doesn't seems to be related to this PR so still approving but raised a separate issue here: #3483

@adecler
Copy link
Member

adecler commented Mar 25, 2025

@BHoMBot check compliance
@BHoMBot check required
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Mar 25, 2025

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check unit-tests

Copy link

bhombot-ci bot commented Mar 25, 2025

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Mar 25, 2025

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@adecler
Copy link
Member

adecler commented Mar 25, 2025

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Mar 25, 2025

@adecler to confirm, the following actions are now queued:

  • check ready-to-merge

@adecler adecler merged commit ad9fddc into develop Mar 25, 2025
13 checks passed
@adecler adecler deleted the BHoM_Engine-#3481-StackOverflowBug branch March 25, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflection_Engine: PropertyFullNameValueGroups causes StackOverflowException
2 participants