Skip to content

BHoM_Engine: Overall compliance fixes #3472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 20, 2025

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #3451

Aiming to fix all compliance failures throughout the BHoM_Engine.

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge type:compliance Non-conforming to code guidelines labels Mar 19, 2025
@IsakNaslundBh IsakNaslundBh self-assigned this Mar 19, 2025
@IsakNaslundBh IsakNaslundBh removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Mar 20, 2025
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check code-compliance
@BHoMBot check documentation-compliance

Copy link

bhombot-ci bot commented Mar 20, 2025

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance

There are 29 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Mar 20, 2025

Please be advised that the check with reference 39120102283 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 13 additional annotations waiting, made up of 0 errors and 13 warnings.

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on

  • code review
  • testing that all code compliance checks are now passing for the BHoM_Engine using
    this script

@adecler
Copy link
Member

adecler commented Mar 20, 2025

@BHoMBot check required

Copy link

bhombot-ci bot commented Mar 20, 2025

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 3 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Mar 20, 2025

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Mar 20, 2025

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check unit-tests
@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Mar 20, 2025

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check unit-tests
  • check ready-to-merge

There are 9 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Mar 20, 2025

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Mar 20, 2025

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh IsakNaslundBh merged commit 528c03e into develop Mar 20, 2025
13 checks passed
@IsakNaslundBh IsakNaslundBh deleted the BHoM_Engine-#3451-FixComplianceIssues branch March 20, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code compliance found during 8.1 uptick
2 participants