Skip to content

Fallback on versioning to upgrade via pipes if direct calling crashes #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Mar 19, 2025

Issues addressed by this PR

Closes #3470

Fixes issues with versioning in net framework environments not compatible with the upgrades dlls.
Tries with the direct call system, by extractign upgrade methods from the upgrader assemblies, and if it fails, sets the system to use the pipes instead.

Explicitly important to get versioning working for Rhino 8.

Test files

Link to GH files that require versioning

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added severity:critical No workaround exists. Essential to continue type:bug Error or unexpected behaviour labels Mar 19, 2025
@IsakNaslundBh IsakNaslundBh self-assigned this Mar 19, 2025
@IsakNaslundBh
Copy link
Contributor Author

IsakNaslundBh commented Mar 19, 2025

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Mar 19, 2025

@IsakNaslundBh to confirm, the following actions are now queued:

  • check versioning

There are 39 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Mar 19, 2025

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check unit-tests

Copy link

bhombot-ci bot commented Mar 19, 2025

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Mar 19, 2025

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Mar 19, 2025

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just tested against Revit 2025 and versioning seems to be working fine 👍

Copy link
Contributor

@jamesramsden-bh jamesramsden-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve from Physics.

Have tested with Environment_Engine/Environment_Model_From_Brep test file (which was previously failing to version correctly in Rhino 8). The GH file now loads correctly in Rh8, and continues to load correctly in Rh7.

Have also tested with Environment_Engine/Environment_Model_Testing, which is a file that does not need versioning. This continues to load correctly as before for both Rhino 7 and 8.

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on

  • Review of the code
  • Testing the provided GH files both in Rhino 7 and Rhino 8.

@adecler
Copy link
Member

adecler commented Mar 19, 2025

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Mar 19, 2025

@adecler to confirm, the following actions are now queued:

  • check ready-to-merge

There are 2 requests in the queue ahead of you.

@adecler adecler merged commit 710f105 into develop Mar 19, 2025
13 checks passed
@adecler adecler deleted the Versioning_Engine-#3470-FallbackToPipesWhenFailingToDirectlyLoadVersioningAssemblies branch March 19, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:critical No workaround exists. Essential to continue type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versioning not functioning when running in some net version
4 participants