-
Notifications
You must be signed in to change notification settings - Fork 13
Fallback on versioning to upgrade via pipes if direct calling crashes #3471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback on versioning to upgrade via pipes if direct calling crashes #3471
Conversation
@BHoMBot check versioning |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 39 requests in the queue ahead of you. |
@IsakNaslundBh to confirm, the following actions are now queued:
|
The check |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just tested against Revit 2025 and versioning seems to be working fine 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve from Physics.
Have tested with Environment_Engine/Environment_Model_From_Brep test file (which was previously failing to version correctly in Rhino 8). The GH file now loads correctly in Rh8, and continues to load correctly in Rh7.
Have also tested with Environment_Engine/Environment_Model_Testing, which is a file that does not need versioning. This continues to load correctly as before for both Rhino 7 and 8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on
- Review of the code
- Testing the provided GH files both in Rhino 7 and Rhino 8.
@BHoMBot check ready-to-merge |
@adecler to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #3470
Fixes issues with versioning in net framework environments not compatible with the upgrades dlls.
Tries with the direct call system, by extractign upgrade methods from the upgrader assemblies, and if it fails, sets the system to use the pipes instead.
Explicitly important to get versioning working for Rhino 8.
Test files
Link to GH files that require versioning
Changelog
Additional comments