Structure_Engine: Geometry3D Panel Extrusion method using wrong thickness and normal vector #3468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Description and Output to refer to panel envelope
Chrisshort92
approved these changes
Mar 7, 2025
|
@IsakNaslundBh or @peterjamesnugent, can you review the code prior to merge? Thanks. |
|
@BHoMBot check required |
|
@lborgenstam to confirm, the following actions are now queued:
|
IsakNaslundBh
approved these changes
Mar 10, 2025
IsakNaslundBh
deleted the
BHoM_Engine-#2852-structure_engine-geometry3dpanel_WrongThicknessAndNormalVector
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Solves issue and adds functionality to Geometry3D for panels. Previously, extrusion of panel was created along global Z-axis, meaning extruded geometry for walls was incorrect. Furthermore, extrusion distance was calculated from VolumePerArea() property, meaning extruded dimension of i.e. Waffle Slab was incorrect.
To fix above, extrusion direction is changed from global Z vector to the normal vector of the panel surface and extrusion distance from VolumePerArea() to TotalThickness().
Closes #2852
Test files
Check different thicknesses and different slab types. Control that results reasonable and like expected.
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM_Engine/Structure_Engine/%232852-Geometry3DPanel-WrongThicknessAndNormalVector/%232852_PanelGeometry3D.gh?csf=1&web=1&e=NYvuMd
Changelog
Additional comments