Diffing_Engine: Fix is equal of DataTable #3456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BHoMBot check serialisation |
|
@IsakNaslundBh to confirm, the following actions are now queued:
|
IsakNaslundBh
changed the title
|
@BHoMBot check compliance |
|
@IsakNaslundBh to confirm, the following actions are now queued:
|
alelom
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Agree with the approach and the code changes.
The provided test script passes correctly.
I've also tested with DiffingTests_Prototypes and everything passes as usual.
Thank you! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #3455
Fix IsEqual check for DataTables by inclusion of local copies of the custom comparers from Kellerman. See issue for more detail.
Test files
On Sharpoint
Serialisation check for the branch should not give warning about tables.
Changelog
Additional comments