Skip to content

Downgrade IsEqual crashing from error to warning #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Dec 12, 2024

NOTE: Depends on

Issues addressed by this PR

#3442

Change crash of IsEqual from error to warning

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Dec 12, 2024
@IsakNaslundBh IsakNaslundBh self-assigned this Dec 12, 2024
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required
@BHoMBot check unit-tests
@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Dec 12, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check unit-tests
  • check dataset-compliance
  • check copyright-compliance

There are 150 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required
@BHoMBot check unit-tests
@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Dec 12, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check unit-tests
  • check dataset-compliance
  • check copyright-compliance

There are 204 requests in the queue ahead of you.

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addresses the issue of serialization checks tagged as failed due to errors in the testing process instead of actual serialization errors.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Dec 12, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 222 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Dec 12, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Dec 12, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

There are 230 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit 06f6da3 into develop Dec 12, 2024
12 checks passed
@IsakNaslundBh IsakNaslundBh deleted the BHoM_Engine-#3442-DowngradeIsEqualCrashToWarning branch December 12, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants