BHoM_Engine: TryRunExtensionMethod made more sensitive to inputs

[pawelbaran]

Issues addressed by this PR

Closes #3424

Test files

See the changes in the test project - review and run the newly added tests.

Changelog

Additional comments

[alelom]

Not sure how to best test it

With unit tests! 😄 That's why I always push for them. I'd put that code you wrote in BHoM_Engine\.ci\unit-tests\BHoM_Engine_Tests.sln. There you can create a "fake" engine project where you can put "fake" extension methods to test stuff like this. Then you can create a unit test to call them in the Base_Engine_Tests project.

I think it's important, especially for foundational stuff like this, that we start building a proper library of tests. But take it as a proposal, I won't enforce in my review. It is hard to test without that though.
For example, I would add another edge case to the list. What happens if we have a public engine method with no argument? Probably nothing, but how do we make sure? Also, is there an edge case where types[0] would throw an index error in this line? Again, probably not, but without running a suite of tests it's always a bit of a risk to know that everything works safely when we touch this kind of foundational code.

[pawelbaran]

Good shout @alelom! I did not know we have a NUnit test solution ready for use. Ported the code over and updated the PR description. Ready for review!

[alelom]

Reviewed and tested with @pawelbaran using the provided Unit Tests. Only change I'd recommend is to make more descriptive names to test where applicable.

[pawelbaran]

@BHoMBot check compliance

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

There are 15 requests in the queue ahead of you.

[pawelbaran]

@BHoMBot check compliance

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[pawelbaran]

@BHoMBot check versioning

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check versioning

There are 19 requests in the queue ahead of you.

[bhombot-ci]

FAO: @adecler @pawelbaran @IsakNaslundBh
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 32529549559

[pawelbaran]

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check unit-tests

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check core
• check null-handling
• check serialisation
• check unit-tests

[pawelbaran]

@BHoMBot check unit-tests

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check unit-tests

[pawelbaran]

@BHoMBot check unit-tests
@BHoMBot check compliance
@BHoMBot check core
@BHoMBot check serialisation
@BHoMBot check null-handling

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check unit-tests
• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check core
• check serialisation
• check null-handling

[pawelbaran]

@BHoMBot check versioning

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check versioning

[bhombot-ci]

FAO: @adecler @pawelbaran @IsakNaslundBh
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 32533482456

[alelom]

Re-approving following previous review. Thank you! 😄

[pawelbaran]

@BHoMBot check installer

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check installer

[pawelbaran]

Dispensating documentation compliance because all failures concern UTs sitting under .ci.

[pawelbaran]

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 32533482456

[bhombot-ci]

@pawelbaran I have now provided a passing check on reference 32533482456 as requested.

[pawelbaran]

@BHoMBot check ready-to-merge

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check ready-to-merge

There are 31 requests in the queue ahead of you.