Skip to content

Type matching based on unqualified names enabled in Create.EngineType #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pawelbaran
Copy link
Member

Issues addressed by this PR

Closes #3385
Closes #3386

Test files

Passing serialisation and versioning checks should be enough of verification.

Changelog

Additional comments

Fix for #3385 is almost self-explanatory, while #3386 requires a bit of explanation I believe. The origin of the bug is renaming of Revit assemblies that led me to finding out that Create.EngineType matches types based on fully qualified name - after renaming the assemblies the old and new names are different, resulting in a failure. Two steps were required to address that:

  1. Enabling matching by unqualified name
  2. Enabling picking first type in case of finding multiple matching types, similar to what we did with @IsakNaslundBh in BHoM_Engine: creation of type in case of multiple matching types fixed #3344

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Jul 31, 2024
@pawelbaran pawelbaran requested a review from IsakNaslundBh July 31, 2024 09:59
@pawelbaran pawelbaran self-assigned this Jul 31, 2024
@pawelbaran
Copy link
Member Author

@BHoMBot check compliance
@BHoMBot check serialisation
@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jul 31, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check serialisation
  • check versioning

There are 23 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance
@BHoMBot check serialisation
@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jul 31, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check serialisation
  • check versioning

There are 38 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Jul 31, 2024

The check branch-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@pawelbaran
Copy link
Member Author

@BHoMBot check versioning
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Aug 5, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check versioning
  • check serialisation

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with changes made here. Approving based on code review rather than testing, relying on the check versioning in particular to flag any potential issues.

@pawelbaran
Copy link
Member Author

@BHoMBot check installer
@BHoMBot check core
@BHoMBot check compliance
@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Aug 5, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check installer
  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check unit-tests

@pawelbaran
Copy link
Member Author

@BHoMBot check null-handling

Copy link

bhombot-ci bot commented Aug 5, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check null-handling

There are 16 requests in the queue ahead of you.

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to review based on code inspection and the PR checks passing, especially serialisation and versioning.

Copy link

bhombot-ci bot commented Aug 5, 2024

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 28350420492

@pawelbaran
Copy link
Member Author

I am dispensating the failing UT check on the basis of the fact that all reported errors were present in the past (e.g. here). @peterjamesnugent @IsakNaslundBh maybe that's something we could try to clear/fix in the coming sprints?

@pawelbaran
Copy link
Member Author

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 28350420492

Copy link

bhombot-ci bot commented Aug 5, 2024

@pawelbaran I have now provided a passing check on reference 28350420492 as requested.

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Aug 5, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@pawelbaran pawelbaran closed this Aug 5, 2024
@pawelbaran pawelbaran deleted the Revit_MechanicalPlumbing_Tool-#81-WrongAssemblyNamesAndNamespaces branch August 5, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BHoM_Engine: Create.EngineType only works for matching fully qualified types BHoM_Engine: ExtractAssembly does not capture engine types
3 participants