-
Notifications
You must be signed in to change notification settings - Fork 13
Type matching based on unqualified names enabled in Create.EngineType #3387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type matching based on unqualified names enabled in Create.EngineType #3387
Conversation
@pawelbaran to confirm, the following actions are now queued:
There are 23 requests in the queue ahead of you. |
@pawelbaran to confirm, the following actions are now queued:
There are 38 requests in the queue ahead of you. |
The check |
@pawelbaran to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with changes made here. Approving based on code review rather than testing, relying on the check versioning in particular to flag any potential issues.
@pawelbaran to confirm, the following actions are now queued:
|
@BHoMBot check null-handling |
@pawelbaran to confirm, the following actions are now queued:
There are 16 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to review based on code inspection and the PR checks passing, especially serialisation and versioning.
FAO: @FraserGreenroyd The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with:
|
I am dispensating the failing UT check on the basis of the fact that all reported errors were present in the past (e.g. here). @peterjamesnugent @IsakNaslundBh maybe that's something we could try to clear/fix in the coming sprints? |
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 28350420492 |
@pawelbaran I have now provided a passing check on reference |
@BHoMBot check ready-to-merge |
@pawelbaran to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #3385
Closes #3386
Test files
Passing
serialisation
andversioning
checks should be enough of verification.Changelog
Additional comments
Fix for #3385 is almost self-explanatory, while #3386 requires a bit of explanation I believe. The origin of the bug is renaming of Revit assemblies that led me to finding out that
Create.EngineType
matches types based on fully qualified name - after renaming the assemblies the old and new names are different, resulting in a failure. Two steps were required to address that: