-
Notifications
You must be signed in to change notification settings - Fork 13
Structure_Engine: Add Geometry3D method for Pile, PileCap and PileFoundation #3348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure_Engine: Add Geometry3D method for Pile, PileCap and PileFoundation #3348
Conversation
Geometry3D for pile and pad foundations added to Structure_Engine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functionality has been tested and the code successfully creates the 3D visualizations required. The code has been checked and is ok to be merged.
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 26 requests in the queue ahead of you. |
@Chrisshort92 see the documentation compliance failures. Good to fix before merging! |
@BHoMBot check compliance |
@BHoMBot check compliance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes needed, particularly the Pile
method for Geometry3D
.
Co-authored-by: Peter Nugent <[email protected]>
Co-authored-by: Peter Nugent <[email protected]>
Co-authored-by: Peter Nugent <[email protected]>
Co-authored-by: Peter Nugent <[email protected]>
Co-authored-by: Peter Nugent <[email protected]>
@BHoMBot check compliance |
@Chrisshort92 to confirm, the following actions are now queued:
There are 9 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the changes, I have retested the updated code. The method functions as it should and can be merged.
@BHoMBot check required |
@peterjamesnugent to confirm, the following actions are now queued:
|
The check |
The check |
Changes address, the changes to the Pile Geometry3D require larger scale changes to be picked up in a separate PR
@peterjamesnugent to confirm, the following actions are now queued:
There are 37 requests in the queue ahead of you. |
FAO: @FraserGreenroyd The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 25943790975 |
@FraserGreenroyd I have now provided a passing check on reference |
Issues addressed by this PR
Closes #3347
Geometry3D for pile and pad foundations added to Structure_Engine
Test files
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM_Engine/Structure_Engine/%233347-add-geometry3d-for-piles-and-foundations/%233347-TypicalPileFoundation_Geometry3D_TestScript.gh?csf=1&web=1&e=44L3qr
Changelog
Pile
,PadFoundation
andPileFoundation
;Additional comments