Skip to content

Structure_Engine: Add Geometry3D method for Pile, PileCap and PileFoundation #3348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Chrisshort92
Copy link
Contributor

@Chrisshort92 Chrisshort92 commented May 22, 2024

Issues addressed by this PR

Closes #3347

Geometry3D for pile and pad foundations added to Structure_Engine

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM_Engine/Structure_Engine/%233347-add-geometry3d-for-piles-and-foundations/%233347-TypicalPileFoundation_Geometry3D_TestScript.gh?csf=1&web=1&e=44L3qr

Changelog

  • Added Geometry3D method for Pile, PadFoundation and PileFoundation;

Additional comments

Geometry3D for pile and pad foundations added to Structure_Engine
@Chrisshort92 Chrisshort92 requested a review from eden-reynell May 22, 2024 19:12
@Chrisshort92 Chrisshort92 linked an issue May 22, 2024 that may be closed by this pull request
@Chrisshort92 Chrisshort92 marked this pull request as ready for review May 22, 2024 19:14
eden-reynell
eden-reynell previously approved these changes May 28, 2024
Copy link

@eden-reynell eden-reynell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality has been tested and the code successfully creates the 3D visualizations required. The code has been checked and is ok to be merged.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check compliance

Copy link

bhombot-ci bot commented May 28, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 26 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor

@Chrisshort92 see the documentation compliance failures. Good to fix before merging!

@Chrisshort92
Copy link
Contributor Author

@BHoMBot check compliance

@Chrisshort92
Copy link
Contributor Author

@BHoMBot check compliance

@peterjamesnugent peterjamesnugent changed the title Update Geometry3D.cs Structure_Engine: Add Geometry3D method for Pile, PileCap and PileFoundation May 29, 2024
@peterjamesnugent peterjamesnugent added this to the BHoM 7.2 β MVP milestone May 29, 2024
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes needed, particularly the Pile method for Geometry3D.

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Jun 4, 2024
@Chrisshort92
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jun 7, 2024

@Chrisshort92 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 9 requests in the queue ahead of you.

Copy link

@eden-reynell eden-reynell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the changes, I have retested the updated code. The method functions as it should and can be merged.

@peterjamesnugent
Copy link
Member

@BHoMBot check required

Copy link

bhombot-ci bot commented Jun 7, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Jun 7, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jun 7, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@peterjamesnugent peterjamesnugent dismissed their stale review June 7, 2024 11:31

Changes address, the changes to the Pile Geometry3D require larger scale changes to be picked up in a separate PR

@peterjamesnugent
Copy link
Member

@BHoMBot check unit-tests
@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jun 7, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests
  • check ready-to-merge

There are 37 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Jun 7, 2024

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 25943790975

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 25943790975

Copy link

bhombot-ci bot commented Jun 7, 2024

@FraserGreenroyd I have now provided a passing check on reference 25943790975 as requested.

@FraserGreenroyd FraserGreenroyd merged commit fa7184b into develop Jun 7, 2024
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Structure_Engine-#3347-add-geometry3d-for-piles-and-foundations branch June 7, 2024 13:57
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structure_Engine: Add Geometry3D for Piles and Foundations
5 participants