Skip to content

Diffing_Engine: IsEqual method added #3338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2024

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Apr 26, 2024

NOTE: Depends on

Issues addressed by this PR

Supports closing out BHoM/Test_Toolkit#473

Test files

Very raw test file uploaded on SharePoint, also diffing test project written by @alelom

Changelog

Additional comments

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Apr 26, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 7 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Apr 26, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check unit-tests

There are 6 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@alelom @IsakNaslundBh @FraserGreenroyd I ran the unit-tests check against develop under #3339 - the failures are exactly the same as on this branch, so I according to my best understanding, this PR together with BHoM/Test_Toolkit#474 is neutral for the existing tests.

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance
@BHoMBot check core

Copy link

bhombot-ci bot commented Apr 29, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core

@pawelbaran
Copy link
Member Author

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Apr 29, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check versioning

Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, tested with Grasshopper Script and BHoM/DiffingTests_Prototypes#21

@pawelbaran
Copy link
Member Author

@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check installer

Copy link

bhombot-ci bot commented May 7, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation
  • check installer

There are 49 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented May 7, 2024

FAO: @FraserGreenroyd
@pawelbaran is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 24303460733

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 24303460733

Copy link

bhombot-ci bot commented May 7, 2024

@FraserGreenroyd I have now provided a passing check on reference 24303460733 as requested.

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented May 7, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@pawelbaran pawelbaran merged commit 82a1c1f into develop May 7, 2024
@pawelbaran pawelbaran deleted the Test_Toolkit-#473-ReplaceKellermanWithDiffing branch May 7, 2024 15:47
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants