Skip to content

Facade_Engine: Updated AW methods to handle Cavity UValue #3316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

vgreen-BH
Copy link
Contributor

Issues addressed by this PR

Closes #3315

Updated UValueOpeningAW and UValueSpandrelAW methods so that the Cavity UValue fragment is only applied to the center of the opening and not to the edges.

Test files

New check has been added under section 5 of the SpandrelAWTestFile: https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/03_Alpha/BHoM/BHoM_Engine/Facade_Engine/BHoM%20PR%20Test%20Files?csf=1&web=1&e=pf2Sja

@vgreen-BH vgreen-BH added this to the BHoM 7.1 β MVP milestone Mar 11, 2024
@vgreen-BH vgreen-BH requested a review from enarhi March 11, 2024 23:01
@vgreen-BH vgreen-BH self-assigned this Mar 11, 2024
Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with test script and calculated values with spandrel are as expected.

@enarhi
Copy link
Member

enarhi commented Mar 12, 2024

@BHoMBot check required

Copy link

bhombot-ci bot commented Mar 12, 2024

@enarhi sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

Copy link

bhombot-ci bot commented Mar 12, 2024

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 12 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Mar 13, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance
  • check ready-to-merge

There are 47 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Mar 13, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd added the type:bug Error or unexpected behaviour label Mar 13, 2024
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Mar 13, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 72 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit b774be5 into develop Mar 13, 2024
@FraserGreenroyd FraserGreenroyd deleted the Facade_Engine-#3315-CavityUValueHandling branch March 13, 2024 11:52
@FraserGreenroyd FraserGreenroyd changed the title Updated AW methods to handle Cavity UValue Facade_Engine: Updated AW methods to handle Cavity UValue Mar 13, 2024
@FraserGreenroyd
Copy link
Contributor

@vgreen-BH @enarhi just a gentle reminder to include change log labels and which engine is impacted most by your PR for future PRs - helps our automated systems for change logs 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UValueSpandrelAW and UValueOpening AW handling of Cavity Fragment
3 participants