-
Notifications
You must be signed in to change notification settings - Fork 13
Facade_Engine: Updated AW methods to handle Cavity UValue #3316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facade_Engine: Updated AW methods to handle Cavity UValue #3316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with test script and calculated values with spandrel are as expected.
@BHoMBot check required |
@enarhi sorry, I didn't understand. |
@enarhi to confirm, the following actions are now queued:
There are 12 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 47 requests in the queue ahead of you. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 72 requests in the queue ahead of you. |
@vgreen-BH @enarhi just a gentle reminder to include change log labels and which engine is impacted most by your PR for future PRs - helps our automated systems for change logs 😄 |
Issues addressed by this PR
Closes #3315
Updated UValueOpeningAW and UValueSpandrelAW methods so that the Cavity UValue fragment is only applied to the center of the opening and not to the edges.
Test files
New check has been added under section 5 of the SpandrelAWTestFile: https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/03_Alpha/BHoM/BHoM_Engine/Facade_Engine/BHoM%20PR%20Test%20Files?csf=1&web=1&e=pf2Sja