Skip to content

BHoM_Engine: Use NetStandard version of DeepCloner in Nugets rather than NetFramework #3281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

FraserGreenroyd
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd commented Feb 14, 2024

Fixes #3223

This is based on this Nuget report which highlights the netstandard1.3 is a supported version for DeepCloner, and as such has a computed support package up to net5.0 and net6.0 crucially for the tools being prototyped across the BHoM community.

Ultimate proof will be in the nuget produced at the end of this sprint, hopefully will resolve the warning and error.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check core
@BHoMBot check versioning
@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Feb 14, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check core
  • check versioning
  • check null-handling
  • check serialisation

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: installer, unit-tests, ready-to-merge

Copy link

bhombot-ci bot commented Feb 14, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Contributor

@albinber albinber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change make sense, approving

@FraserGreenroyd FraserGreenroyd merged commit da1de7e into develop Feb 14, 2024
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#3223-DeepClonerUpgrade branch February 14, 2024 12:22
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix missing dependencies on DeepCloner or replace DeepCloner with something that supports net standard 2.0
2 participants