Skip to content

Analytical_Engine: Align with Graph namespace elevation #3238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

FraserGreenroyd
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM#1580

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jan 12, 2024
@FraserGreenroyd FraserGreenroyd self-assigned this Jan 12, 2024
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd FraserGreenroyd marked this pull request as ready for review January 12, 2024 10:43
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check serialisation
@BHoMBot check null-handling

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check serialisation
  • check null-handling

There are 3 requests in the queue ahead of you.

Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On code review, approving based on linked PR, also approving the erroneous capitals in ToDataVizObjects

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd FraserGreenroyd merged commit d15fd17 into develop Jan 12, 2024
@FraserGreenroyd FraserGreenroyd deleted the Analytical_oM-#1261-ElevateGraph branch January 12, 2024 15:25
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants