Skip to content

Reflection_Engine: support methods for legacy attributes removed #3233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

pawelbaran
Copy link
Member

NOTE: Depends on

BHoM/BHoM#1577

Issues addressed by this PR

Closes #

Test files

See BHoM/BHoM#1577.

Changelog

Additional comments

@pawelbaran pawelbaran added the type:compliance Non-conforming to code guidelines label Jan 5, 2024
@pawelbaran pawelbaran self-assigned this Jan 5, 2024
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

Copy link

bhombot-ci bot commented Jan 5, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Jan 5, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@pawelbaran
Copy link
Member Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 8, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 14 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on oM review and code review. Thanks @pawelbaran

Copy link

bhombot-ci bot commented Jan 8, 2024

@pawelbaran just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM

Copy link

bhombot-ci bot commented Jan 8, 2024

@pawelbaran just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @pawelbaran on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Jan 8, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Jan 8, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link

bhombot-ci bot commented Jan 8, 2024

@pawelbaran just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd FraserGreenroyd merged commit d53362f into develop Jan 8, 2024
@FraserGreenroyd FraserGreenroyd deleted the BHoM-#1544-RemoveLegacyAttributes branch January 8, 2024 13:51
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants