Skip to content

Facade_Engine: Spandrel u-value calculation method #3177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 8, 2023

Conversation

vgreen-BH
Copy link
Contributor

@vgreen-BH vgreen-BH commented Sep 7, 2023

NOTE: Depends on

BHoM/BHoM#1553

Issues addressed by this PR

Closes #3145

  • Adds method for calculating area weighted u-value of a spandrel opening using methods per NFRC 100.
  • Updates OpeningAW calculation method to call spandrel calculation when req'd, based on assigned OpeningType

Test files

Test File

@vgreen-BH vgreen-BH added the type:feature New capability or enhancement label Sep 7, 2023
@vgreen-BH vgreen-BH added this to the BHoM 6.3 β MVP milestone Sep 7, 2023
@vgreen-BH vgreen-BH requested a review from enarhi September 7, 2023 22:42
@vgreen-BH vgreen-BH requested a review from al-fisher as a code owner September 7, 2023 22:42
@vgreen-BH vgreen-BH self-assigned this Sep 7, 2023
@enarhi
Copy link
Member

enarhi commented Sep 7, 2023

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 7, 2023

@enarhi to confirm, the following actions are now queued:

  • check installer

@enarhi
Copy link
Member

enarhi commented Sep 8, 2023

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@enarhi to confirm, the following actions are now queued:

  • check installer

@enarhi
Copy link
Member

enarhi commented Sep 8, 2023

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with the test file and opening calcs are correct per spandrel/vision types, and warnings and errors are intuitive.

@enarhi
Copy link
Member

enarhi commented Sep 8, 2023

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@enarhi
Copy link
Member

enarhi commented Sep 8, 2023

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@enarhi to confirm, the following actions are now queued:

  • check unit-tests

There are 5 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 2 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 16602599617

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 16602599617

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@FraserGreenroyd I have now provided a passing check on reference 16602599617 as requested.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@vgreen-BH just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd FraserGreenroyd merged commit b78e99b into develop Sep 8, 2023
@FraserGreenroyd FraserGreenroyd deleted the Facade_Engine-#3145-SpandrelUValueMethod branch September 8, 2023 10:15
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
Development

Successfully merging this pull request may close these issues.

Facade_Engine: Calculation Method to Calculate Spandrel Specific U-value for Opening
3 participants