-
Notifications
You must be signed in to change notification settings - Fork 13
Facade_Engine: Spandrel u-value calculation method #3177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facade_Engine: Spandrel u-value calculation method #3177
Conversation
@BHoMBot check installer |
@enarhi to confirm, the following actions are now queued:
|
@BHoMBot check installer |
@enarhi to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@enarhi to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested with the test file and opening calcs are correct per spandrel/vision types, and warnings and errors are intuitive.
@BHoMBot check required |
@enarhi to confirm, the following actions are now queued:
|
The check |
The check |
The check |
@BHoMBot check unit-tests |
@enarhi to confirm, the following actions are now queued:
There are 5 requests in the queue ahead of you. |
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
FAO: @FraserGreenroyd The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 16602599617 |
@FraserGreenroyd I have now provided a passing check on reference |
@vgreen-BH just to let you know, I have provided a |
NOTE: Depends on
BHoM/BHoM#1553
Issues addressed by this PR
Closes #3145
Test files
Test File