Skip to content

Ground_Engine: Add project for ground related objects and associated engine methods #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

peterjamesnugent
Copy link
Member

NOTE: Depends on

BHoM/BHoM#1548

Issues addressed by this PR

Closes #3173

Add project for future development in 6.4 milestone

Test files

CI/CD

Changelog

  • Added Ground_Engine for future development planned in 6.4 milestone

Additional comments

@peterjamesnugent peterjamesnugent self-assigned this Sep 5, 2023
@peterjamesnugent peterjamesnugent added the type:feature New capability or enhancement label Sep 5, 2023
@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 30 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the bots happy then this is a reasonable addition in advance of objects coming in during draft PRs without merging prior to the 6.3 beta to avoid versioning issues as discussed offline with @peterjamesnugent

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check dataset-compliance

There are 21 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

@peterjamesnugent just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 5, 2023

@peterjamesnugent just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd FraserGreenroyd merged commit 4418142 into develop Sep 5, 2023
@FraserGreenroyd FraserGreenroyd deleted the Ground_oM-#1548-AddProjectForGroundRelatedObjects branch September 5, 2023 21:13
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ground_Engine: Add project for methods related to new ground objects
2 participants