-
Notifications
You must be signed in to change notification settings - Fork 13
Facade_Engine: Added PsiValuesMatch method and OpeningsSAM check for matching #3133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the PsiValuesMatch and OpeningsSAM methods with matching and different psi value inputs for adjacent edges.
Expected result occured in both cases. Matching psi value inputs gives the correct ouput U value and different adjacent psi value inputs gives an error stating that adjacent edges must have the same psi value.
@BHoMBot check compliance |
@enarhi to confirm, the following actions are now queued:
|
@BHoMBot check required |
@enarhi to confirm, the following actions are now queued:
|
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the PsiValuesMatch and OpeningsSAM methods with matching and different psi value inputs for adjacent edges.
Expected result occured in both cases. Matching psi value inputs gives the correct ouput U value and different adjacent psi value inputs gives an error stating that adjacent edges must have the same psi value.
@BHoMBot check unit-tests |
@enarhi to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
FAO: @FraserGreenroyd The check they wish to have dispensation on is unit-tests. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 15755410361 |
@FraserGreenroyd I have now provided a passing check on reference |
@BHoMBot check ready-to-merge |
@enarhi to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@enarhi to confirm, the following actions are now queued:
|
1 similar comment
@enarhi to confirm, the following actions are now queued:
|
The check |
@enarhi to confirm, the following actions are now queued:
|
The check |
@enarhi to confirm, the following actions are now queued:
|
The check |
Issues addressed by this PR
Closes #3132
Closes #3013
Added method to check that adjacent frame edges have matching PsiValues, as mismatching PsiValues indicates an error in frame properties that needs to be resolved before running the calc.
Test files
Test file