Skip to content

Facade_Engine: Added PsiValuesMatch method and OpeningsSAM check for matching #3133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

enarhi
Copy link
Member

@enarhi enarhi commented Aug 4, 2023

Issues addressed by this PR

Closes #3132
Closes #3013

Added method to check that adjacent frame edges have matching PsiValues, as mismatching PsiValues indicates an error in frame properties that needs to be resolved before running the calc.

Test files

Test file

Copy link

@AhmedElnagar1 AhmedElnagar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PsiValuesMatch and OpeningsSAM methods with matching and different psi value inputs for adjacent edges.
Expected result occured in both cases. Matching psi value inputs gives the correct ouput U value and different adjacent psi value inputs gives an error stating that adjacent edges must have the same psi value.

@enarhi
Copy link
Member Author

enarhi commented Aug 9, 2023

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@enarhi
Copy link
Member Author

enarhi commented Aug 9, 2023

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

@AhmedElnagar1 AhmedElnagar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PsiValuesMatch and OpeningsSAM methods with matching and different psi value inputs for adjacent edges.
Expected result occured in both cases. Matching psi value inputs gives the correct ouput U value and different adjacent psi value inputs gives an error stating that adjacent edges must have the same psi value.

@enarhi
Copy link
Member Author

enarhi commented Aug 9, 2023

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

@enarhi to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 9, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 10, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 15755410361

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 15755410361

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 10, 2023

@FraserGreenroyd I have now provided a passing check on reference 15755410361 as requested.

@enarhi
Copy link
Member Author

enarhi commented Aug 10, 2023

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 10, 2023

@enarhi to confirm, the following actions are now queued:

  • check ready-to-merge

@enarhi enarhi self-assigned this Aug 10, 2023
@enarhi enarhi added the type:feature New capability or enhancement label Aug 10, 2023
@enarhi
Copy link
Member Author

enarhi commented Aug 10, 2023

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 10, 2023

@enarhi to confirm, the following actions are now queued:

  • check ready-to-merge

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Aug 10, 2023

@enarhi to confirm, the following actions are now queued:

  • check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 10, 2023

The check ready-to-merge has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 10, 2023

@enarhi to confirm, the following actions are now queued:

  • check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 10, 2023

The check ready-to-merge has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd FraserGreenroyd merged commit 3ee9f92 into develop Aug 10, 2023
@FraserGreenroyd FraserGreenroyd deleted the Facade_Engine-#3132-PsiCheckMethod branch August 10, 2023 17:37
@bhombot-ci
Copy link

bhombot-ci bot commented Aug 10, 2023

@enarhi to confirm, the following actions are now queued:

  • check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 10, 2023

The check ready-to-merge has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
3 participants