Skip to content

Serialiser_Engine: Minor spelling fix for error passed to UI #3063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Jun 5, 2023

Minor spelling error found during other testing. Didn't raise an issue for this as it's so incredibly minor it didn't seem worth it.

Issues addressed by this PR

Test files

Changelog

Additional comments

Minor spelling error found during other testing. Didn't raise an issue for this as it's so incredibly minor it didn't seem worth it.
@tg359 tg359 added severity:low Doesn't stop/slow current workflow size:XS Measured in seconds priority:low Resources should be targeted to other issues first labels Jun 5, 2023
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of @IsakNaslundBh 's best spellings there - I think @jamesramsden-bh has previously fixed a few too! 😄

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I'm gonna suggest we do this too that I saw as I hit submit review on the last one!

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 5, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 30 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 5, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 5, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 5, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests
  • check ready-to-merge

There are 31 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 5, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is unit-tests.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14013645706

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 14013645706

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 5, 2023

@FraserGreenroyd I have now provided a passing check on reference 14013645706 as requested.

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jun 5, 2023
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 5, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit b0d8143 into develop Jun 5, 2023
@FraserGreenroyd FraserGreenroyd deleted the Serialiser_Engine-#XX-MinorSpellingFix branch June 5, 2023 16:24
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Resources should be targeted to other issues first severity:low Doesn't stop/slow current workflow size:XS Measured in seconds type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants