Serialiser_Engine: Add isUpgraded argument to DeprecateSerialiser and pass on bool

[IsakNaslundBh]

Issues addressed by this PR

Closes #3055

Add isUpgraded argument to DeprecateSerialiser and pass on bool

Especially critical for the call to this made from the main Deserialise method when the type upgrader failed, as this was the mechanism able to cause an infinite loop

Test files

CheckVerisoning should still pass.

Was trying to figure out a way to add a UT for this, but could not think of a simple case that is not to involved, as it require type upgrader to fail, but an explicit upgrader to run and return a faulty type.

Changelog

Additional comments

[FraserGreenroyd]

The changes made to the code make sense given the bug presented and am happy for this to be deployed for further testing.

[FraserGreenroyd]

@BHoMBot check compliance
@BHoMBot check required
@BHoMBot check unit-tests

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer
• check unit-tests

There are 16 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[adecler]

The code changes makes sense.
Discussed a potential edge case with @IsakNaslundBh and am happy that all is working as it should be.

[FraserGreenroyd]

@BHoMBot check unit-tests

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check unit-tests

[FraserGreenroyd]

@BHoMBot check unit-tests

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check unit-tests

[FraserGreenroyd]

@BHoMBot check ready-to-merge

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check ready-to-merge

[FraserGreenroyd]

@BHoMBot check unit-tests

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check unit-tests

[FraserGreenroyd]

@BHoMBot check unit-tests

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check unit-tests

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

[bhombot-ci]

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.