Skip to content

Geometry_Engine: Fix StartPoint for NurbsCurve #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Feb 9, 2023

Issues addressed by this PR

Closes #435

Fix correctly getting out the StartPoint of NurbsCurve via point at parameter

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/EkJFzOyIs8hLlgzaTaVCjM8BbhxlyfcvV3Vr0bELfMXBKQ?e=m6r5Bu

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Feb 9, 2023
@IsakNaslundBh IsakNaslundBh requested a review from EKAdebo February 9, 2023 15:56
@IsakNaslundBh IsakNaslundBh self-assigned this Feb 9, 2023
@IsakNaslundBh IsakNaslundBh changed the title Fix StartPoint for NurbsCurve Geometry_engine: Fix StartPoint for NurbsCurve Feb 9, 2023
@IsakNaslundBh IsakNaslundBh changed the title Geometry_engine: Fix StartPoint for NurbsCurve Geometry_Engine: Fix StartPoint for NurbsCurve Feb 9, 2023
Copy link

@EKAdebo EKAdebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the test, the code works as expected.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 9, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 9, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run the test script on todays alpha, and am getting the error regarding the start point for nurbs curve. I have then run the test script on this pull request and the error is gone, and the points are available, so I'm happy for this pull request from the hack session to be deployed.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning
@BHoMBot check serialisation
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 10, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check serialisation
  • check unit-tests

There are 4 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 10, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check null-handling

There are 1 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: null-handling, documentation-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 10, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 10, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 1 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 4294c3f into develop Feb 10, 2023
@FraserGreenroyd FraserGreenroyd deleted the Geometry_Engine-#435-FixStartPointForNurbsCurve branch February 10, 2023 15:45
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geometry_Engine: Query.StartPoint failing for NurbsCurve
3 participants