-
Notifications
You must be signed in to change notification settings - Fork 13
Geometry_Engine: Fix StartPoint for NurbsCurve #3003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry_Engine: Fix StartPoint for NurbsCurve #3003
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the test, the code works as expected.
@IsakNaslundBh to confirm, the following actions are now queued:
|
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have run the test script on todays alpha, and am getting the error regarding the start point for nurbs curve. I have then run the test script on this pull request and the error is gone, and the points are available, so I'm happy for this pull request from the hack session to be deployed.
@FraserGreenroyd to confirm, the following actions are now queued:
There are 4 requests in the queue ahead of you. |
@BHoMBot check null-handling |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: null-handling, documentation-compliance |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #435
Fix correctly getting out the StartPoint of NurbsCurve via point at parameter
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/EkJFzOyIs8hLlgzaTaVCjM8BbhxlyfcvV3Vr0bELfMXBKQ?e=m6r5Bu
Changelog
Additional comments