-
Notifications
You must be signed in to change notification settings - Fork 13
BHoM_Engine: Add methods to record events from exceptions #2998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some potential centralisation fo logic to single method RecordEvent that all other new methods can call.
Also, if we want to make use of the stacktrace from the event, we need to change the main RecordEvent method that currently overwrites it.
@BHoMBot check compliance |
1 similar comment
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitty gritty desc, apart from that, from just code inspection, looks good. Will test and if all clear, approve
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
|
The check |
The check |
The check |
The check |
@BHoMBot check null-handling |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 18 requests in the queue ahead of you. |
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 6 requests in the queue ahead of you. |
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 2 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, and functioning as intended
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 6 requests in the queue ahead of you. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: null-handling |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
Issues addressed by this PR
Fixes #2011
Additional comments
Code review should be suitable for these methods.