Skip to content

Geometry_Engine: project along lowercase character compliance #2991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kprusicka
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #2990

Character changed to lowercase.

Test files

Changelog

Additional comments

@kprusicka kprusicka added the type:compliance Non-conforming to code guidelines label Jan 12, 2023
@kprusicka kprusicka requested a review from pawelbaran as a code owner January 12, 2023 17:07
@kprusicka kprusicka self-assigned this Jan 12, 2023
@kprusicka kprusicka force-pushed the Geometry_Engine-#2990-ProjectAlongLowercaseCharacter branch from bc9e84d to 73817b7 Compare January 12, 2023 17:15
@kprusicka
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2023

@kprusicka to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd FraserGreenroyd changed the title Geometry engine #2990 project along lowercase character Geometry_Engine: project along lowercase character compliance Jan 12, 2023
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is null-handling.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 10611239267

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 10611233820

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 10611239267

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2023

@FraserGreenroyd I have now provided a passing check on reference 10611239267 as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 10611233820

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2023

@FraserGreenroyd I have now provided a passing check on reference 10611233820 as requested.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This meets the requirements of the issue, thanks @kprusicka

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 53ec04d into develop Jan 12, 2023
@FraserGreenroyd FraserGreenroyd deleted the Geometry_Engine-#2990-ProjectAlongLowercaseCharacter branch January 12, 2023 17:40
@kprusicka
Copy link
Contributor Author

Dziekuje @BHoMBot

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2023

@kprusicka you're very welcome! 😄

@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geometry_Engine: Method input should have lowercase character
2 participants